-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ingest): add HBase source connector plugin #15257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(ingest): add HBase source connector plugin #15257
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Bundle ReportBundle size has no change ✅ |
| "glue = datahub.ingestion.source.aws.glue:GlueSource", | ||
| "sagemaker = datahub.ingestion.source.aws.sagemaker:SagemakerSource", | ||
| "hana = datahub.ingestion.source.sql.hana:HanaSource", | ||
| "hbase = datahub.ingestion.source.sql.hbase:HBaseSource", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additional to the entry point, hbase dependencies should be set here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this rectangle shape may not fit well in the UI, have you checked?
a logo that fits better in a square/circle shape would look better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resized to square
sgomezvillamor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good
I miss:
- unit/integration tests
- some minimal user docs in https://github.com/btkcodedev/datahub/tree/85649af65c0f1e3068d68633b3e983994710eea2/metadata-ingestion/docs/sources
|
Please, double check you followed steps defined here https://docs.datahub.com/docs/metadata-ingestion/adding-source Eg I miss updates in |
Changes Made:Backend:
Frontend:
Documentation:
|
Closes #14733
Summary
Adds an HBase metadata ingestion plugin to DataHub to extract namespaces, tables, column families and schema metadata via the HBase Thrift API. Includes backend source implementation, plugin registration, UI config stubs, docs and minimal wiring to surface the connector in the ingestion UI.
Motivation
Support for HBase metadata ingestion so users can index HBase namespaces/tables into DataHub and make them discoverable, searchable and lineage-able.
What changed
Added backend source implementation
Registered plugin entrypoint
The connector is a StatefulIngestionSourceBase and supports:
Containers: HBase namespaces
Schema metadata: row key + column families / qualifiers
Deletion detection via stateful ingestion
Platform instance and env config
Thrift-based connection (Thrift / happybase recommended)
Compatibility / Risk
No breaking changes.
Requires Thrift-related dependencies and (optionally) UI assets.
If Thrift libs missing, connector logs a clear error and fails to connect.