Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No num_players in Gin Rummy #225

Closed
jkterry1 opened this issue Jun 18, 2021 · 2 comments
Closed

No num_players in Gin Rummy #225

jkterry1 opened this issue Jun 18, 2021 · 2 comments

Comments

@jkterry1
Copy link
Contributor

While gin rummy is a 2 player game and that shouldn't be changed, akin to Dou Dizhu only being a 3 player game, gin rummy still doesn't have the num_players argument the way all other rlcard environments have.

@kaanozdogru
@daochenzha
@daochenzha
Copy link
Member

@justinkterry I have added the num_players. See 49a6613

Do you think it looks good? If so, we will update a PyPI version as well.

@jkterry1
Copy link
Contributor Author

No PyPI release should be needed.

@kaanozdogru does that fix what you were complaining about to me earlier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkterry1 @daochenzha