Bridge hidden card rep error

[YanSong97]

Great lib!

In bridge environment, the hidden card representation seems to have the incorrect hidden_player_ids for a four-player game. Correct me if am wrong, I believe line 237 should be something like hidden_player_ids = [(current_player_id + 1) % 4, (current_player_id + 3) % 4] to get the correct hidden player id. Same applies to line 239.

Appreciate it if you can double-check it.

rlcard/rlcard/envs/bridge.py

Lines 232 to 247 in 517cb08

	hidden_cards_rep = np.zeros(52, dtype=int)
	if not game.is_over():
	if game.round.is_bidding_over():
	declarer = game.round.get_declarer()
	if current_player_id % 2 == declarer.player_id % 2:
	hidden_player_ids = [(current_player_id + 1) % 2, (current_player_id + 3) % 2]
	else:
	hidden_player_ids = [declarer.player_id, (current_player_id + 2) % 2]
	for hidden_player_id in hidden_player_ids:
	for card in game.round.players[hidden_player_id].hand:
	hidden_cards_rep[card.card_id] = 1
	else:
	for player in game.round.players:
	if player.player_id != current_player_id:
	for card in player.hand:
	hidden_cards_rep[card.card_id] = 1

[billh0420]

Thanks for finding this error. I corrected the two lines and submitted a pull request.

[daochenzha]

@billh0420 @YanSong97 Thanks for the fix!