Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column 3 has bad format #6

Open
roll opened this issue Jan 16, 2017 · 5 comments
Open

Column 3 has bad format #6

roll opened this issue Jan 16, 2017 · 5 comments

Comments

@roll
Copy link

roll commented Jan 16, 2017

$ goodtables datapackage http://data.okfn.org/data/core/gdp/datapackage.json
DATASET
=======
{'error-count': 999, 'table-count': 1, 'time': 2.588, 'valid': False}

TABLE [1]
=========
{'datapackage': 'http://data.okfn.org/data/core/gdp/datapackage.json',
 'error-count': 999,
 'headers': ['Country Name', 'Country Code', 'Year', 'Value'],
 'row-count': 1000,
 'source': 'https://raw.githubusercontent.com/datasets/gdp/master/data/gdp.csv',
 'time': 1.948,
 'valid': False}
---------
[2,3] [non-castable-value] Row 2 has non castable value in column 3 (type: date, format: yyyy)
[3,3] [non-castable-value] Row 3 has non castable value in column 3 (type: date, format: yyyy)
...

from frictionlessdata/tableschema-py#145

@rufuspollock
Copy link
Member

@roll that is not a super informative output ;-) - what exactly is wrong with row 2? yyyy should count as a valid date no and the data looks ok:

https://github.com/datasets/gdp/blob/master/data/gdp.csv#L3

@roll
Copy link
Author

roll commented Jan 17, 2017

@rufuspollock
I suppose this format string is just against the prev stable spec (yyyy => fmt:%y): http://specs.frictionlessdata.io/json-table-schema/#date

It looks like the same issue #5 (cc @Fak3)

@Fak3
Copy link

Fak3 commented Jan 17, 2017

Yes. Looking at the spec, the correct type of the column should be 'gyear' http://specs.frictionlessdata.io/json-table-schema/#gyear or 'date' with '%Y' format

@rufuspollock
Copy link
Member

@Fak3 but that type change is very recent. I guess we should change to gyear ... - will that work @roll?

@roll
Copy link
Author

roll commented Jan 20, 2017

@rufuspollock
gyear is not supported yet. Also wasn't there a plan to rename it to year? (we have many moving parts for now..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants