CNDB-14802: Improve async byte allocation estimates in SAI SegmentBuilder #2002
+79
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
michaeljmarshall
force-pushed
the
cndb-14802
branch
from
d3e5c2b to
8edfac0
Compare
Member
Author
|
Some of the tests are failing for unrelated reasons. I pushed a fix for those here #2007 |
Member
Author
|
Merged in |
We no longer block until the first insertion completes, and as such, we need to make sure that isEmpty correctly accounts for inflight inserts. This fixes a flaky test (only flaky for this branch) in the FeaturesVersionSupportTest.
|
eolivelli
requested changes
Nov 28, 2025
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
We should probably improve test coverage on this patch, it seems that we have improved only one existing unit test
| while (condition.get()) | ||
| { | ||
| if (timeoutMs-- <= 0) | ||
| throw new RuntimeException("Timeout while waiting for condition"); |
There was a problem hiding this comment.
do we have unit tests that cover this condition ?
a RuntimeException will bubble up and hit any place in the code
would it be better to return false and handle the timeout explicitly ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
https://github.com/riptano/cndb/issues/14802
What does this PR fix and why was it fixed
This fix works in collaboration with datastax/jvector#521. Specifically, it focuses on removing the estimation aspect of the memory management and instead works by reserving more memory than is expected to be needed, then adjusting the real usage once the actual value of memory required is known. This should help reduce cases where we exceed the bytes used.