Skip to content

Conversation

@ekaterinadimitrova2
Copy link

@ekaterinadimitrova2 ekaterinadimitrova2 commented Nov 11, 2025

What is the issue

...
We want to be able to enable/disable TableStateMetrics.

What does this PR fix and why was it fixed

...
Add a flag to be able to do that - cassandra.sai.metrics.table_state.enabled

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@ekaterinadimitrova2
Copy link
Author

The two newly exposed and not used metrics are needed and tested in CNDB, thus the test coverage is below 100%.

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2119 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.distributed.test.PreviewRepairCoordinatorTimeoutTest.prepareRPCTimeout[SEQUENTIAL/false] REGRESSION 🔵🔴 0 / 17

Found 1 known test failures

@ekaterinadimitrova2 ekaterinadimitrova2 requested review from a team and pkolaczk November 18, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants