Skip to content

Conversation

@k-rus
Copy link
Member

@k-rus k-rus commented Nov 13, 2025

The PR is still in initial state. It compiles and majority of tests are expected to succeed.
It removes usage of Trie for primary key component, which requires additional adjustments. Also it might not be really acceptable.
There are many more small issue to fix:

  • Investigate and fix where Trie based API of sorted terms were used (as mentioned above)
  • Noticed memory leaks
  • Reported disk size is 0 in some cases in SAI disk size test
  • Double check commented or remove code
  • Investigate removed benchmarks
  • May be move IndexFileUtils as in C*
  • Introduce TokenOnlyPrimaryKey class as in C* (improves isTokenOnly implementation)
  • May be move out inner impl classes from IndexDescriptor as in C*
  • Port bug fixes from C*

What is the issue

Fixes https://github.com/riptano/cndb/issues/15608

What does this PR fix and why was it fixed

...

k-rus added 2 commits October 10, 2025 10:46
Add tests to control SAI disk size for different format version and
different partition sizes.
It compiles and tests are working. Many issues still exist.
@k-rus k-rus changed the title [WIP] CNDB-15609 test SAI disk size for all versions [WIP] CNDB-15608 port CASSANDRA-18673 to reduce disk usage of row-aware indexes Nov 14, 2025
Does not require to rely on nullable context.
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 New Blocker Issues (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2122 rejected by Butler


5611 regressions found
See build details here


Found 5611 new test failures

Showing only first 15 new test failures

Test Explanation Runs Upstream
o.a.c.distributed.test.FailingRepairTest.testFailingMessage[101/dc_parallel/false] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.FailingRepairTest.testFailingMessage[101/sequential/true] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.VectorDistributedTest.rangeRestrictedTest REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryCellDeletionsTest.testCellDeletions[CompositePartitionKeyDataModel] REGRESSION 🔵🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryCellDeletionsTest.testCellDeletions[CompoundKeyDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryCellDeletionsTest.testCellDeletions[CompoundKeyWithStaticsDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryRowDeletionsTest.testRowDeletions[CompositePartitionKeyDataModel] REGRESSION 🔵🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryRowDeletionsTest.testRowDeletions[CompoundKeyDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryRowDeletionsTest.testRowDeletions[CompoundKeyWithStaticsDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryTimeToLiveTest.testTimeToLive[CompositePartitionKeyDataModel] REGRESSION 🔵🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryTimeToLiveTest.testTimeToLive[CompoundKeyDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryTimeToLiveTest.testTimeToLive[CompoundKeyWithStaticsDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryWriteLifecycleTest.testWriteLifecycle[CompositePartitionKeyDataModel] REGRESSION 🔵🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryWriteLifecycleTest.testWriteLifecycle[CompoundKeyDataModel] REGRESSION 🔴🔴 0 / 17
o.a.c.distributed.test.sai.datamodels.QueryWriteLifecycleTest.testWriteLifecycle[CompoundKeyWithStaticsDataModel] REGRESSION 🔴🔴 0 / 17

Found 11 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants