Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate stories to storybook 8 #675

Closed
3 tasks
dvdanielamoitzi opened this issue Jan 13, 2025 · 0 comments
Closed
3 tasks

Migrate stories to storybook 8 #675

dvdanielamoitzi opened this issue Jan 13, 2025 · 0 comments
Assignees
@dvdanielamoitzi @dvlilialbrecht
Labels
type: feature New feature or request

Comments

@dvdanielamoitzi
Copy link
Contributor

dvdanielamoitzi commented Jan 13, 2025 •
edited
Loading

Short description

Storybook has been updated to storybook 8 in this PR. Our stories are outdated, as the ComponentStory is not supported anymore. That's why we have to migrate all our stories.

Resources

Steps

  • Barchart stories
    • Coordinate with Usama which Barchart stories are needed / up to date
    • Presumably vis -> Bar are the latest stories
    • Delete outdated stories (example -> vis)
  • Hooks stories
    • Coordinate with Moritz which hooks are needed / can be removed from stories
  • Violin plot
    • Coordinate with Martin which stories are the most up to date (I guess Violin test)

Structure

  • VIS
    • vis types (bar, violin, ...)
    • vis hooks
  • UI Elements
    • header
  • Hooks
@dvdanielamoitzi dvdanielamoitzi added the type: feature New feature or request label Jan 13, 2025
@dvlilialbrecht dvlilialbrecht mentioned this issue Jan 15, 2025
Merged
puehringer added a commit that referenced this issue Jan 17, 2025
@puehringer
Migrating stories to storybook 8 (#682)
620029e 
Closes #675 

Since in the newest storybook version ComponentStory is not available
anymore, it had to be deleted.
Now all stories use a Meta Object, which gives an outline for the
stories.
There are also no templates anymore, but a StoryObj, from which stories
can be created.

See reference
[https://storybook.js.org/docs/writing-stories#using-args](here)

To fix eslint errors, following lines were added:
`// eslint-disable-next-line react-hooks/rules-of-hooks`

Directory structure of stories was also changed.

![image](https://github.com/user-attachments/assets/7caacb81-73a4-40d1-8973-3f2e0d2dcb2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvdanielamoitzi dvdanielamoitzi

@dvlilialbrecht dvlilialbrecht

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@puehringer @dvdanielamoitzi @dvlilialbrecht