Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient accumulation + DDP scenario #94

Open
Dengligedeng opened this issue Jan 22, 2025 · 0 comments
Open

Gradient accumulation + DDP scenario #94

Dengligedeng opened this issue Jan 22, 2025 · 0 comments

Comments

@Dengligedeng
Copy link

Thanks very much for the great work. I think if grad acc and DDP is used, gradients will only do all-reduce in optimizer's closure calling time. Besides, the closure will only contains last batch's training data and can't do step2's gradient recalculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant