Skip to content

refactor: adapt changes out of release 3.0.0 by DB UI core #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0e4aaff
refactor: updated DB UI Core version
mfranzke Aug 6, 2024
5005fec
refactor: adapted the HTML changes out of DB UI Core
mfranzke Aug 6, 2024
cab0794
fix(chip): remove aria-hidden to expose label in a11y tree (#2659)
jonaskuske Aug 6, 2024
fe51496
refactor: updated snapshots
mfranzke Aug 6, 2024
f1b5b98
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Aug 8, 2024
bc477ff
chore: update snapshots
nmerget Aug 8, 2024
2a794f2
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Jun 16, 2025
48661d8
refactor: we need to ignore the h function import
mfranzke Jun 16, 2025
7021e0f
refactor: updated to DB UI Core Version 3.3.4
mfranzke Jun 16, 2025
29e7cb3
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Jun 17, 2025
312539d
refactor: downgraded zone.js to prevent a conflict
mfranzke Jun 17, 2025
c5400d5
Merge branch '2709-refactor-adapt-changes-out-of-release-300-by-db-ui…
mfranzke Jun 17, 2025
56b0591
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Jun 17, 2025
88b9af1
refactor: regenerated package lock file
mfranzke Jun 17, 2025
25501d2
refactor: added relevant field
mfranzke Jul 14, 2025
5a1eabd
fix: structure
mfranzke Jul 14, 2025
e2e3d9c
docs: added documentation on the regeneration of snapshots
mfranzke Jul 14, 2025
baa1dea
test: updated snapshots
mfranzke Jul 14, 2025
33f8ade
refactor: optimized build
mfranzke Jul 14, 2025
c790120
Update README.md
mfranzke Jul 14, 2025
1e0f7a4
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Jul 15, 2025
819eecc
refactor: reverted screenshot
mfranzke Jul 15, 2025
3177453
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Jul 15, 2025
70661e2
refactor: reverted screenshots
mfranzke Jul 15, 2025
e0287d5
refactor: shouldn't include a paragraph
mfranzke Jul 15, 2025
aec21bf
refactor: removed obsolete declaration
mfranzke Jul 15, 2025
0bc29a9
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Jul 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions e2e/cypress/e2e/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Regenerate snapshots

In case that your snapshot tests fail, you would need to regenerate the snapshots.

```bash
npm run start
```

and in parallel:

```bash
npm run cypress:snapshot:base
```
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,6 @@
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
"homepage": "https://db-ui.github.io/elements/"
"homepage": "https://db-ui.github.io/elements/",
"packageManager": "[email protected]"
}
4 changes: 2 additions & 2 deletions packages/db-ui-elements-angular/projects/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "lib",
"version": "0.0.1",
"peerDependencies": {
"@angular/common": "^17.3.11",
"@angular/core": "^17.3.11"
"@angular/common": "^17.3.12",
"@angular/core": "^17.3.12"
},
"dependencies": {
"tslib": "^2.6.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/db-ui-elements-stencil/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"puppeteer": "^24.0.0"
},
"dependencies": {
"@db-ui/core": "^2.22.0"
"@db-ui/core": "^3.3.4"
},
"license": "Apache-2.0",
"publishConfig": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ export class DbBrand {
rel={this.anchorRelation}
>
<img src={this.src} alt={this.alt} class="elm-image is-logo" />
{this.siteNameLink && (
<span class="is-site-name">
<slot />
</span>
)}
</a>
{this.siteNameLink && (
<span class="is-site-name">
<slot />
</span>
)}
{!this.siteNameLink && (
<span class="is-site-name">
<slot />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ There are 3 options to use &lt;db-breadcrumb&gt;:
<db-breadcrumb aria-label="Breadcrumb">
<db-link href="#">Startseite</db-link>
<db-link href="#">Page XYZ</db-link>
<db-link href="#" current="location">
Page ZYS
</db-link>
<db-link href="#" current="location">Page ZYS</db-link>
</db-breadcrumb>
</Canvas>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import { Component, Host, h, Prop } from '@stencil/core';
import { uuid } from '../../utils/utils';

Expand Down Expand Up @@ -75,12 +76,7 @@ export class DbChip {
name={this.name}
checked={this.selected}
/>
<label
htmlFor={this.input_id}
role="button"
aria-hidden="true"
data-variant={this.variant}
>
<label htmlFor={this.input_id} data-variant={this.variant}>
{this.icon ? <db-icon variant="20-outline" icon={this.icon} /> : null}
<slot />
{this.iconafter ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@ A header component.
<db-header>
<db-brand>DB-UI Elements</db-brand>
<db-mainnavigation>
<db-link href="#" rel="index" current="page">
Startseite
</db-link>
<db-link href="#" rel="offers">
Aufträge
</db-link>
<db-link href="#" rel="index" current="page">Startseite</db-link>
<db-link href="#" rel="offers">Aufträge</db-link>
</db-mainnavigation>
</db-header>
</Canvas>
Expand All @@ -37,12 +33,8 @@ A header component.
<db-brand>DB-UI Elements</db-brand>
<db-meta>
<db-metanavigation>
<db-link icon="settings" href="#">
Einstellungen
</db-link>
<db-link icon="chat" icononly href="#">
Nachrichten
</db-link>
<db-link icon="settings" href="#">Einstellungen</db-link>
<db-link icon="chat" icononly href="#">Nachrichten</db-link>
</db-metanavigation>
</db-meta>
</db-header>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,8 @@ There are three options to use &lt;db-language-switcher&gt;:

<Canvas>
<db-language-switcher aria-selected-index="1">
<db-link title="English language" href="#">
EN
</db-link>
<db-link title="Deutsche Sprache" href="#">
DE
</db-link>
<db-link title="English language" href="#">EN</db-link>
<db-link title="Deutsche Sprache" href="#">DE</db-link>
</db-language-switcher>
</Canvas>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ The `<db-link></db-link>` element represents a control. With its href attribute,
Icons can be used in link to help give their functionality more clarity at a glance. Define an icon by it's identifier (like e.g. download, compare to [DB UI Icons](https://db-ui.github.io/core/patterns/base-icons/index.html)).

<Canvas>
<db-link href="#" icon="alarm">
Link
</db-link>
<db-link href="#" icon="alarm">Link</db-link>
</Canvas>

<db-headline variant="2">target</db-headline>
Expand All @@ -41,12 +39,8 @@ The target attribute specifies the browsing context and gives different visual e
</p>

<Canvas>
<db-link href="#" target="_self">
internal
</db-link>
<db-link href="#" target="_blank">
external
</db-link>
<db-link href="#" target="_self">internal</db-link>
<db-link href="#" target="_blank">external</db-link>
</Canvas>

<Markdown>{Readme}</Markdown>
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
@import '../general';
@import 'mainnavigation';

a {
@extend .elm-link;
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,10 @@ There are 3 options to use &lt;db-mainnavigation&gt;; out of the first two, we s
<Canvas>
<db-mainnavigation>
<li>
<db-link href="#" current="page">
Startseite
</db-link>
<db-link href="#" current="page">Startseite</db-link>
</li>
<li>
<db-link href="#">
Aufträge
</db-link>
<db-link href="#">Aufträge</db-link>
</li>
<li>
{/* You could as well use a general hyperlink HTML tag */}
Expand All @@ -62,38 +58,26 @@ There are 3 options to use &lt;db-mainnavigation&gt;; out of the first two, we s
</a>
<ul>
<li>
<db-link href="#">
Subul 01
</db-link>
<db-link href="#">Subul 01</db-link>
<ul>
<li>
<db-link href="#">
Sub 01 Sub 01
</db-link>
<db-link href="#">Sub 01 Sub 01</db-link>
</li>
<li>
<db-link href="#">
Sub 01 Sub 02
</db-link>
<db-link href="#">Sub 01 Sub 02</db-link>
</li>
<li>
<db-link href="#">
Sub 01 Sub 03
</db-link>
<db-link href="#">Sub 01 Sub 03</db-link>
</li>
</ul>
</li>
</ul>
</li>
<li>
<db-link href="#">
Aufträge
</db-link>
<db-link href="#">Aufträge</db-link>
<ul>
<li>
<db-link href="#">
Subul 02
</db-link>
<db-link href="#">Subul 02</db-link>
</li>
</ul>
</li>
Expand All @@ -116,12 +100,8 @@ There are 3 options to use &lt;db-mainnavigation&gt;; out of the first two, we s

<Canvas>
<db-mainnavigation>
<db-link href="#" rel="index" current="page">
Startseite
</db-link>
<db-link href="#" rel="offers">
Aufträge
</db-link>
<db-link href="#" rel="index" current="page">Startseite</db-link>
<db-link href="#" rel="offers">Aufträge</db-link>
</db-mainnavigation>
</Canvas>

Expand All @@ -142,9 +122,7 @@ There are 3 options to use &lt;db-mainnavigation&gt;; out of the first two, we s
<db-link href="#">Sub2 Sub 2</db-link>
</db-link>
</db-link>
<db-link href="#" rel="offers">
Aufträge
</db-link>
<db-link href="#" rel="offers">Aufträge</db-link>
</db-mainnavigation>
</Canvas>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,8 @@ Use [&lt;li&gt; (**l**ist **i**tem)](https://developer.mozilla.org/en-US/docs/We

<Canvas>
<db-metanavigation>
<db-link icon="settings" href="#">
Einstellungen
</db-link>
<db-link icon="chat" icononly href="#">
Nachrichten
</db-link>
<db-link icon="settings" href="#">Einstellungen</db-link>
<db-link icon="chat" icononly href="#">Nachrichten</db-link>
</db-metanavigation>
</Canvas>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,12 @@ Use [&lt;li&gt; (**l**ist **i**tem)](https://developer.mozilla.org/en-US/docs/We

<Canvas>
<db-sidenavi>
<db-link rel="index" href="#" aria-current="page">
Startseite
</db-link>
<db-link rel="documents" href="#">
Dokumente
</db-link>
<db-link icon="settings" href="#">
Einstellungen
</db-link>
<db-link icon="chat" href="#">
Nachrichten
</db-link>
<db-link rel="calendar" href="#">
Kalender
</db-link>
<db-link rel="help" href="#">
Frage &amp; Hilfe
</db-link>
<db-link rel="index" href="#" aria-current="page">Startseite</db-link>
<db-link rel="documents" href="#">Dokumente</db-link>
<db-link icon="settings" href="#">Einstellungen</db-link>
<db-link icon="chat" href="#">Nachrichten</db-link>
<db-link rel="calendar" href="#">Kalender</db-link>
<db-link rel="help" href="#">Frage &amp; Hilfe</db-link>
</db-sidenavi>
</Canvas>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class GithubVersionSwitcher {
if (foundGroup) {
foundGroup.branches.push(branch);
} else {
this.groups.at(-1).branches.push(branch);
this.groups[3].branches.push(branch);
}
});
this.setCurrentBranch(branchNames);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<p>Link list:</p>
<db-linklist>
<li>
<db-link href="https://db-ui.github.io/elements/" target="_blank">
DB UI Elements components documentation
</db-link>
<db-link href="https://db-ui.github.io/elements/" target="_blank"
>DB UI Elements components documentation</db-link
>
</li>
<li>
<db-link href="https://db-ui.github.io/elements/" target="_blank">
DB UI Core components documentation
</db-link>
<db-link href="https://db-ui.github.io/elements/" target="_blank"
>DB UI Core components documentation</db-link
>
</li>
</db-linklist>
<p>Notification:</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
height="253"
></db-image>
<p>DbLink:</p>
<db-link href="https://github.com/db-ui/elements/" target="_blank">
DB UI Elements components documentation
</db-link>
<db-link href="https://github.com/db-ui/elements/" target="_blank"
>DB UI Elements components documentation</db-link
>
<p>DbLogo:</p>
<db-logo></db-logo>
</div>
8 changes: 2 additions & 6 deletions showcase/playground-showcase/src/editor/snippets.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,8 @@ const snippet3 = `

const snippet4 = `
<db-mainnavigation>
<db-link href="#" rel="index" aria-current="page">
Startseite
</db-link>
<db-link href="#" rel="offers">
Aufträge
</db-link>
<db-link href="#" rel="index" aria-current="page">Startseite</db-link>
<db-link href="#" rel="offers">Aufträge</db-link>
</db-mainnavigation>

<db-headline variant="1">Headline 1</db-headline>
Expand Down
Loading
Loading