Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for every().weekday()? #129

Open
chrism2671 opened this issue Feb 20, 2017 · 11 comments
Open

Support for every().weekday()? #129

chrism2671 opened this issue Feb 20, 2017 · 11 comments

Comments

@chrism2671
Copy link

This would be a handy addition.

@heisen273
Copy link

why don't you use every().day instead?

@chrism2671
Copy link
Author

Just aiming for Monday-Friday

@furudean
Copy link

This also brings with the issue that different cultures have different weekdays, so hopefully that could be implemented in some way as well.

@candyfaz
Copy link

candyfaz commented Sep 12, 2017

@chrism2671 @Whimzee One of the major factors I use this library is because of its simplicity. Also, shouldn't all such strict implementation logic be outside of the library itself ?

@furudean
Copy link

@Fauzan-M What do you suggest? Ignore non-western culture in favor of simplicity? As far as I know there is no easy way to implement this outside of the library.

@candyfaz
Copy link

candyfaz commented Sep 12, 2017

@Whimzee It should be build more like a calender-middleware layer sitting outside of scheduler (running every minute!). And all your calendar rules should reside within that middleware layer. Just a suggestion !!

@contang0
Copy link

contang0 commented Feb 2, 2018

Ignore non-western culture in favor of simplicity?

Yes.

@jchacks
Copy link

jchacks commented Mar 28, 2018

You could check the DoW in the job and run it daily...

@BenjiLewis
Copy link

BenjiLewis commented Nov 5, 2018

I would really love this feature.

@BenjiLewis
Copy link

It seems like this Pull Request would also suit my needs. #238

@gigittygit
Copy link

Is custom calendar still in the scope?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants