Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dbt_experimental_sample_mode environment variable gate #11228

Open
1 task done
Tracked by #11226
QMalcolm opened this issue Jan 22, 2025 · 0 comments
Open
1 task done
Tracked by #11226

Remove dbt_experimental_sample_mode environment variable gate #11228

QMalcolm opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request sample_mode
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jan 22, 2025

Housekeeping

  • I am a maintainer of dbt-core

Short description

Once "sample mode" is relatively stable, we should remove the environment variable dbt_experimental_sample_mode gating of the functionality. We should do this either as part of the beta, but at the latest needs to happen before the GA of dbt-core 1.10.0.

Acceptance criteria

  • The environment variable gating for sample mode has been removed

Suggested Tests

  • the environment variable dbt_experimental_sample_mode has no effect on one's ability to run in "sample_mode"

Impact to Other Teams

N/A

Will backports be required?

No, it's a new feature

Context

#11227

@QMalcolm QMalcolm added enhancement New feature or request sample_mode labels Jan 22, 2025
@QMalcolm QMalcolm added this to the v1.10 milestone Jan 22, 2025
@QMalcolm QMalcolm changed the title remove dbt_experimental_sample_mode environment variable gate Remove dbt_experimental_sample_mode environment variable gate Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sample_mode
Projects
None yet
Development

No branches or pull requests

1 participant