Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specifying sample time window in project configs #11232

Open
1 task done
Tracked by #11226
QMalcolm opened this issue Jan 23, 2025 · 0 comments
Open
1 task done
Tracked by #11226

Allow for specifying sample time window in project configs #11232

QMalcolm opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request sample_mode
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jan 23, 2025

Housekeeping

  • I am a maintainer of dbt-core

Short description

In #11231 we introduced the ability to set a time window for sample mode as a CLI arg. This should also be able to be provided from the project configs so that it doesn't need to be provided as a CLI arg every time.

Acceptance criteria

  • A sample time window can be specified in the project configs
  • The CLI arg takes priority over the project config if both are provided

Suggested Tests

  • A sample time window can be specified in the project configs
  • The CLI arg takes priority over the project config if both are provided

Impact to Other Teams

N/A

Will backports be required?

No, it's a new feature

Context

N/A

@QMalcolm QMalcolm added sample_mode enhancement New feature or request labels Jan 23, 2025
@QMalcolm QMalcolm added this to the v1.10 milestone Jan 23, 2025
@QMalcolm QMalcolm changed the title allow for specifying sample time window in project configs Allow for specifying sample time window in project configs Jan 23, 2025
@QMalcolm QMalcolm self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sample_mode
Projects
None yet
Development

No branches or pull requests

1 participant