Contributing #1291
Replies: 1 comment
-
@nstein-gpjoule This is perfect - thank you for opening a GitHub discussion (it's the right place to have it). I appreciate you raising this question and would love to dig into the specifics of that feature request as well as our broader approach. In terms of the feature request for materialized views on Snowflake, after multiple conversations with the Snowflake streaming team as well as our own opininated team, we remain of the opinion that we do not want to recommend using materialized views to our users. This is because we believe dynamic tables are more appropriate for analytics transformations due to a few reasons including the current limitations of MVs that Snowflake does not currently plan to improve upon. Due to this and the prioritization of other features, we are not accepting PRs for supporting Materialized Views. That's not to say I'm not open to it but we believe that there are more impactful features we should be focused on as well as maintaining. Since users can already create custom materializations, there are no blockers to using MVs in the dbt project if you so choose.
|
Beta Was this translation helpful? Give feedback.
-
Hi @amychen1776,
I didn't want to start a discussion in #1101, so I opened one here.
I was also looking for this feature and was willing to contribute. However, as I understood, dbt only accepts PRs if they are committed to supporting the proposed feature long-term / it is already on the product roadmap. Is this correct?
This approach is a bit different from what I'm used to with other open source projects, and you might want to include this information in the CONTRIBUTING.md. Perhaps even make the roadmap public?
I think it's beneficial to communicate this policy clearly. Otherwise, people might become frustrated if their work is rejected.
Cheers,
Nils
Beta Was this translation helpful? Give feedback.
All reactions