Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table comment setting in Iceberg tables #1299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix table comment setting in Iceberg tables #1299

wants to merge 2 commits into from

Conversation

dlouseiro
Copy link

@dlouseiro dlouseiro commented Jan 28, 2025 •
edited
Loading

resolves #1298
docs dbt-labs/docs.getdbt.com/#

Problem

Persisting table comments in Iceberg tables fails as comment on ... is ... notation does not work for Iceberg tables.

Solution

  • Update snowflake__alter_relation_comment to set relation_type = 'iceberg table' when the is_iceberg_format is True.
  • Change code to use alter <relation type> ... set comment = ... notation instead of comment on ... is ... notation

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@dlouseiro dlouseiro requested a review from a team as a code owner January 28, 2025 12:05
@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 28, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @dlouseiro

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Setting a comment does not work with Iceberg tables
1 participant
@dlouseiro