Skip to content

Commit 07706df

Browse files
authored
feat: increase maximum message size (#61)
A batch can contain up to 1024 rows. If the columns contain large amounts of data (json blogs or free text), the total batch size can exceed the max message size. By doubling this we should be able to accommodate most use cases. TODO: if we hear of people reaching this max, maybe we should make it configurable.
1 parent f5e4eb2 commit 07706df

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kind: Features
2+
body: Double the max message size
3+
time: 2024-12-13T10:47:39.843647-07:00

dbtsl/api/adbc/client/base.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ def _extra_db_kwargs(cls) -> Dict[str, str]:
2323
return {
2424
DatabaseOptions.WITH_COOKIE_MIDDLEWARE.value: "true",
2525
f"{DatabaseOptions.RPC_CALL_HEADER_PREFIX.value}user-agent": env.PLATFORM.user_agent,
26+
# double the default max msg size in case of queries with large batches
27+
DatabaseOptions.WITH_MAX_MSG_SIZE.value: f"{1024 * 1024 * 32}",
2628
}
2729

2830
def __init__( # noqa: D107

0 commit comments

Comments
 (0)