-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions for ddev-drupal-solr and Drupal 7 #44
Comments
For context, Drupal 7 is EOL on 05 Jan 2025; around 3 weeks from today. |
Yes, exactly! The "lets wait and see" people (often those with larger / more complex D7 sites using solr) are out of time to wait, and are doing things with their old sites now :D In some cases using new developers (ahem) who need to get these old D7 sites working on ddev. I was able to get my site working on ddev using My steps were as follows: For ddev:
Edit the
I did
In Drupal:
|
PRs are always welcome. They may take some to get merged, especially at this time of year, but other developers will find the information helpful! |
Yes @jenlampton please do a PR on the README adding a section "Installation on Drupal 7" with your info. Super easy. You can even use the Github web UI to do it (click the pencil at upper right on https://github.com/ddev/ddev-drupal-solr/blob/main/README.md ) |
I have created https://github.com/ddev/ddev-drupal-solr/pull/45/files, which is maybe too much information. I'm going to create an alternate PR that removes all the views instrucitons incase that would be preferable. |
Okay, this one might be more palettable :) |
Just FYI, you don't have to create new PRs to change things, you can push new info into an existing PR. |
@rfay but then how to do compare the two options? Oh -- would you prefer separate commits? I usually like to have all of my change in a single commit. I suppose they could be squashed easily enough! We usually do separate PRs to compare options. Force of habit, I suppose! |
It's easier for reviewers if you just do the thing you think is best, then reply to suggestions. The bottom line is that you're the reigning expert here, and your suggestion is going to get accepted without trouble. |
My preference is for the more verbose documentation, since that information was hard to locate. I'll close the other PR and we can adjust as per feedback. |
I expect there will be a handful of larger Drupal 7 sites suddenly getting attention now that EOL draws near. Could we add some docs on how to get Drupal 7 + Search API running with this add-on? I have not figured it out yet, but if/once I do I'll be happy to file a PR against the README if interested.
The text was updated successfully, but these errors were encountered: