Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add data update automation #44

Open
B13rg opened this issue Sep 26, 2024 · 9 comments
Open

Feature/Add data update automation #44

B13rg opened this issue Sep 26, 2024 · 9 comments
Labels
enhancement New feature or request infra Codebase infrastructure, deployment, and CI changes

Comments

@B13rg
Copy link
Contributor

B13rg commented Sep 26, 2024

This is an issue to capture the work to:

  • create github action that checks for, generates the data, and creates a PR for the latest released version
  • trigger automation through workflow_dispatch
  • script that updates files based on steam api or seeing that files in an s3 bucket have changed
  • investigate creating github releases for each game update release
@B13rg B13rg added the enhancement New feature or request label Sep 26, 2024
@B13rg
Copy link
Contributor Author

B13rg commented Sep 27, 2024

@hassayag
Copy link
Member

Also if its possible, a way to automate uploading to s3. Right now its just me remembering each patch, but that doesn't consider:

  • Me missing each major patch
  • The changes made in minor patches that don't come with a forum announcement

I have no idea how to do this, I know you can use steamdb to download older versions of a game, so maybe some routine that lets us download nad upload the last X patches that are missing

@hassayag
Copy link
Member

create github action that checks for, generates the data, and creates a PR for the latest released version

Oo I like! We should consider alternate routes for the data upload. I hate the massive diffs that we need to deal with.

What are your thoughts on a separate repo to house the output data?

@B13rg
Copy link
Contributor Author

B13rg commented Oct 2, 2024

Yeah, a separate repo might be the way to go. then it might be easier to give each version it's own folder.
Looking at stuff, the github runner could use https://github.com/Skippeh/steamfetch-action to download the game files.
The credentials will be stored as repo secrets (read only).
It could be triggered by a manual_dispatch, and generate the output based on the version.
We could also limit who could run it, either to specific users or class of user.

I'm not sure how 2-factor auth will behave, unless there's some sort of steam-api key that can be generated/used instead of username+password+2fa

@hassayag hassayag added the infra Codebase infrastructure, deployment, and CI changes label Oct 3, 2024
@hassayag
Copy link
Member

hassayag commented Oct 3, 2024

Created a specific ticket for release tagging in #61 . feel free to flesh it out

@hassayag
Copy link
Member

hassayag commented Oct 3, 2024

Similarly with #64

@B13rg
Copy link
Contributor Author

B13rg commented Oct 4, 2024

Added a workflow to the deadlock-data repo that will sync itself off of this repo's data, it should hopefully be easy to build on!
You can manually trigger it, it'll sync against this repo: https://github.com/deadlock-wiki/deadlock-data/actions/workflows/scheduled-sync.yml

@B13rg
Copy link
Contributor Author

B13rg commented Oct 9, 2024

Example run: deadlock-wiki/deadlock-data@f657dee

@hassayag
Copy link
Member

hassayag commented Nov 7, 2024

@B13rg is this issue still relevant? As there is crossover with other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infra Codebase infrastructure, deployment, and CI changes
Projects
None yet
Development

No branches or pull requests

2 participants