Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use numbers in ouputted item data and ignore zeroes #77

Open
hassayag opened this issue Oct 15, 2024 · 0 comments
Open

Use numbers in ouputted item data and ignore zeroes #77

hassayag opened this issue Oct 15, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hassayag
Copy link
Member

A lot of item data uses strings in the output, when they are actually just numbers. This should be changed to use the num_utils.assert_number(value) to convert to a float or int type

Additionally there are a lot of "0" attributes on items, which should instead just not be assigned to the parsed object
@hassayag hassayag added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hassayag