feat: improve Add performance

orisano · deckarep · commit 29bd72cb4a51 · 2022-03-28T17:27:30.000-07:00
diff --git a/threadunsafe.go b/threadunsafe.go
@@ -42,13 +42,9 @@ func newThreadUnsafeSet[T comparable]() threadUnsafeSet[T] {
 }
 
 func (s *threadUnsafeSet[T]) Add(v T) bool {
-	_, found := (*s)[v]
-	if found {
-		return false //False if it existed already
-	}
-
+	prevLen := len(*s)
 	(*s)[v] = struct{}{}
-	return true
+	return prevLen != len(*s)
 }
 
 func (s *threadUnsafeSet[T]) Cardinality() int {

Original file line number	Diff line number	Diff line change
`@@ -42,13 +42,9 @@ func newThreadUnsafeSet[T comparable]() threadUnsafeSet[T] {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`func (s *threadUnsafeSet[T]) Add(v T) bool {`
`45`		`- _, found := (*s)[v]`
`46`		`- if found {`
`47`		`- return false //False if it existed already`
`48`		`- }`
`49`		`-`
	`45`	`+ prevLen := len(*s)`
`50`	`46`	`(*s)[v] = struct{}{}`
`51`		`- return true`
	`47`	`+ return prevLen != len(*s)`
`52`	`48`	`}`
`53`	`49`
`54`	`50`	`func (s *threadUnsafeSet[T]) Cardinality() int {`