fix(ci): fix mirrord health probes and certificate paths (#1547)

Fixed mirrord local development setup for both virtualization-controller and virtualization-api:
1. Health probes removal: Modified mirrord.sh to remove livenessProbe and readinessProbe from the mirrored container (alpine sleep
container) to prevent probe failures.
2. Certificate path fix: Set TMPDIR=/tmp in both mirrord tasks to ensure os.TempDir() returns /tmp for macOS, matching the certificate mount path in pods (/tmp/k8s-webhook-server/serving-certs).
3. Typo fix: Corrected certificate path typos in apiserver task: virtualziation → virtualization.

Signed-off-by: Daniil Loktev <[email protected]>
(cherry picked from commit 5e96206)
Signed-off-by: Maksim Fedotov <[email protected]>

Author: loktev-d

images/virtualization-artifact/Taskfile.yaml

@@ -72,7 +72,7 @@ tasks:
     deps:
       - _ensure:mirrord
     cmd: |
-      ./hack/mirrord.sh run --app=$PWD/cmd/virtualization-controller/main.go \
+      TMPDIR=/tmp ./hack/mirrord.sh run --app=$PWD/cmd/virtualization-controller/main.go \
       --deployment=virtualization-controller                                 \
       --namespace={{ .BaseNamespace }}                                       \
       --container-name=virtualization-controller
@@ -92,15 +92,15 @@ tasks:
       flags+=( "--kubevirt-cabundle=/etc/virt-api/certificates/ca.crt" )
       flags+=( "--kubevirt-endpoint=virt-api.{{ .BaseNamespace }}.svc" )
       flags+=( "--secure-port=8443" )
-      flags+=( "--tls-private-key-file=/etc/virtualziation-api/certificates/tls.key" )
-      flags+=( "--tls-cert-file=/etc/virtualziation-api/certificates/tls.crt" )
+      flags+=( "--tls-private-key-file=/etc/virtualization-api/certificates/tls.key" )
+      flags+=( "--tls-cert-file=/etc/virtualization-api/certificates/tls.crt" )
       flags+=( "--v=7" )
-      flags+=( "--proxy-client-cert-file=/etc/virtualziation-api-proxy/certificates/tls.crt" )
-      flags+=( "--proxy-client-key-file=/etc/virtualziation-api-proxy/certificates/tls.key" )
+      flags+=( "--proxy-client-cert-file=/etc/virtualization-api-proxy/certificates/tls.crt" )
+      flags+=( "--proxy-client-key-file=/etc/virtualization-api-proxy/certificates/tls.key" )
       flags+=( "--service-account-name=virtualization-api" )
       flags+=( "--service-account-namespace={{ .BaseNamespace }}" )
 
-      ./hack/mirrord.sh run --app="$PWD/cmd/virtualization-api/main.go" \
+      TMPDIR=/tmp ./hack/mirrord.sh run --app="$PWD/cmd/virtualization-api/main.go" \
       --deployment="virtualization-api"                                 \
       --namespace="{{ .BaseNamespace }}"                                \
       --flags="\"${flags[@]}\""

images/virtualization-artifact/hack/mirrord.sh

@@ -103,7 +103,7 @@ chmod +x "${BIN_DIR}/${BINARY}"
 if ! kubectl -n "${NAMESPACE}" get "deployment/${NEW_NAME}" &>/dev/null; then
   kubectl -n "${NAMESPACE}" get "deployment/${DEPLOYMENT}" -ojson | \
   jq --arg CONTAINER_NAME "$CONTAINER_NAME" --arg NEW_NAME "$NEW_NAME" '.metadata.name = $NEW_NAME |
-    (.spec.template.spec.containers[] | select(.name == $CONTAINER_NAME) ) |= (.command= [ "/bin/sh", "-c", "--" ] | .args = [ "while true; do sleep 60; done;" ] | .image = "alpine:3.20.1") |
+    (.spec.template.spec.containers[] | select(.name == $CONTAINER_NAME) ) |= (.command= [ "/bin/sh", "-c", "--" ] | .args = [ "while true; do sleep 60; done;" ] | .image = "alpine:3.20.1" | del(.livenessProbe) | del(.readinessProbe)) |
     .spec.replicas = 1 |
     .spec.template.metadata.labels.mirror = "true" |
     .spec.template.metadata.labels.ownerName = $NEW_NAME' | \