Skip to content

Commit 7375bfa

Browse files
authored
chore(core): fix RBAC for cdi-operator (#1729)
Signed-off-by: Maksim Fedotov <[email protected]>
1 parent e8e70b4 commit 7375bfa

File tree

2 files changed

+6
-33
lines changed

2 files changed

+6
-33
lines changed

.dmtlint.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ linters-settings:
1313
- "spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.contentType"
1414
rbac:
1515
exclude-rules:
16-
# We exclude RBAC rules for virt-operator because it creates ClusterRoles and ClusterRoleBindings with wildcards.
17-
# If we remove wildcard, virt-operator will be unable to create them, as it does not have wildcard permissions itself.
16+
# We exclude RBAC rules for virt-operator and cdi-operator because they create ClusterRoles and ClusterRoleBindings with wildcards.
17+
# If we remove wildcard, virt-operator and cdi-operator will be unable to create them, as they do not have wildcard permissions themselves.
1818
wildcards:
1919
- kind: ClusterRole
2020
name: d8:virtualization:kubevirt-operator
21+
- kind: ClusterRole
22+
name: d8:containerized-data-importer:cdi-operator
2123

2224
# We exclude RBAC rules for CDI and Kubevirt resources because they are used by upstream deployments.
2325
# Changing these rules will require patching upstream code.

templates/cdi/cdi-operator/rbac-for-us.yaml

Lines changed: 2 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -41,40 +41,11 @@ rules:
4141
- delete
4242
- apiGroups:
4343
- cdi.internal.virtualization.deckhouse.io
44-
resources:
45-
- internalvirtualizationcdiconfigs
46-
- internalvirtualizationcdis
47-
- internalvirtualizationcdis/finalizers
48-
- internalvirtualizationdataimportcrons
49-
- internalvirtualizationdatasources
50-
- internalvirtualizationdatavolumes
51-
- internalvirtualizationobjecttransfers
52-
- internalvirtualizationstorageprofiles
53-
- internalvirtualizationvolumeclonesources
54-
- internalvirtualizationvolumeimportsources
55-
- internalvirtualizationvolumeuploadsources
56-
- internalvirtualizationopenstackvolumepopulators
57-
- internalvirtualizationovirtvolumepopulators
58-
verbs:
59-
- get
60-
- list
61-
- watch
62-
- create
63-
- update
64-
- patch
65-
- delete
66-
- apiGroups:
6744
- upload.cdi.kubevirt.io
6845
resources:
69-
- uploadtokenrequests
46+
- '*'
7047
verbs:
71-
- get
72-
- list
73-
- watch
74-
- create
75-
- update
76-
- patch
77-
- delete
48+
- '*'
7849
- apiGroups:
7950
- admissionregistration.k8s.io
8051
resources:

0 commit comments

Comments
 (0)