-
Notifications
You must be signed in to change notification settings - Fork 7
Fix: 单个用户的并发会话限制,修改su命令 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates the Debian login UTMP‐writing patch to ensure that su sessions correctly update /var/run/utmp, so that pam_limits can accurately count concurrent sessions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @luojiahao11 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
aaronUniontech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aaronUniontech The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 2.40.4-3deepin6 |
var/run/utmp don't be updated after logout
|
@luojiahao11: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
由于pam_limits库通过读取 var/run/utmp 文件进行判断并发会话数量,而使用su命令登录后 utmp 文件并没有更新,故添加更新逻辑
Summary by Sourcery
Enable utmp writing for su sessions to enforce per-user concurrent session limits via pam_limits, and add corresponding Debian packaging patch.
Bug Fixes:
Build: