generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 82
Add XGB & SKL Py handlers with CSV/json support #2906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
smouaa
merged 7 commits into
deepjavalibrary:master
from
smouaa:sklearn-handler-csv-support
Oct 22, 2025
Merged
Add XGB & SKL Py handlers with CSV/json support #2906
smouaa
merged 7 commits into
deepjavalibrary:master
from
smouaa:sklearn-handler-csv-support
Oct 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e9e644 to
f7fdcdb
Compare
Lokiiiiii
requested changes
Oct 2, 2025
|
Note: Add tests, benchmarks |
|
Note: Add documentation and demo notebook |
09d3a83 to
81af1b6
Compare
Lokiiiiii
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some tests for -
- CSV inputs - with & without headers
- multiple model artifacts
- Improper ENV variable setup
- garbage string in
SKLEARN_SKOPS_TRUSTED_TYPES - unsupported accept types
- Different input shapes
- Ragged arrays in input
- Add security controls for pickle formats via environment variables - Add import_utils module for optional dependency management - Update Dockerfile to include sklearn dependencies - Made model file discovery a shared helper function in utils.py file
81af1b6 to
46c862c
Compare
46c862c to
548d787
Compare
Lokiiiiii
requested changes
Oct 15, 2025
a577fbf to
8342035
Compare
…ython from 3.10 to 3.11
494473f to
1769295
Compare
Lokiiiiii
requested changes
Oct 18, 2025
Lokiiiiii
requested changes
Oct 20, 2025
bfb5054 to
bcfa8c1
Compare
Lokiiiiii
requested changes
Oct 21, 2025
…ed behavior (accepting properties via serving.properties or env variables, throwing error when csv files contain non numeric data)
bd57507 to
2fd9054
Compare
Lokiiiiii
approved these changes
Oct 22, 2025
ksuma2109
pushed a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B