Skip to content

Consider change 'artifact.json' and putting it in a build directory #231

Open
@fdrozdowski

Description

@fdrozdowski

This is from Rafe:

Need better name than artifact.json. This is a very general name, however, it does represent something specific. Namely the internal representation of a delphix plugin. Consider generating this to some kind of build directory instead of the top level. Also note if this is something that should be checked in to source control?
Consider putting the generated stuff that users are not expected to edit by hand in a type of build directory. If users are not meant to edit these make sure that is made explicit everywhere. Also determine if users are expected to check it into source control.

I agree with much of this sentiment. Particularly a build directory. One great thing about Gradle (and not so great thing about Python setuptools) is that it is standardized that everything goes into a single folder. This makes clean up and writing .gitignore files really easy.

(Source: PYT-538)

Grant:

We talked as a team and decided that we're okay with "artifact.json" as the name of the file. However, we all agree that there should be a build directory. This is a nice to have and not a blocker for GA
A nice to have would be to also put the .delphix_compile folder in the build directory too. This is a folder that is used for temp files needed for swagger code gen.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions