Empty username on windows causes error during upload

[fdrozdowski]

I've attached an image showing the error.

When we give an empty string for a username on windows, it seems like it gets completely ignored, causing the --password= to be picked up as the username instead

This was with 0.4.0-internal-008.

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2019-05-01 at 11.48.45 PM.png | Screen Shot 2019-07-28 at 1.36.11 PM.png | Screen Shot 2019-07-29 at 11.14.43 AM.png

[fdrozdowski]

➤ Zachary Burke commented:

PYT-611 turned out to be a duplicate of this. The cascading failures from this kept starting during virtualization_sdk.sdk.negative.test_dvp_upload_empty_user. This is just because of this empty user issue happening in download-logs as well.

When this is being done by automation, the dvp process ends up hanging for the duration of the test scope.

ad\dtully@10-110-238-254 C:\Users\dtully>powershell -Command Set-Location -Path C:\Users\dtully\blackbox_plugin; C:\Users\dtully
\AppData\Roaming\Python\Scripts\dvp upload -e "zb-trunk-sdk.dlpxdc.co" -u "username" --password="password"                          

ad\dtully@10-110-238-254 C:\Users\dtully>powershell -Command Set-Location -Path C:\Users\dtully\blackbox_plugin; C:\Users\dtully
\AppData\Roaming\Python\Scripts\dvp download-logs -e "zb-trunk-sdk.dlpxdc.co" -u "" --password="password"                        
Password: <---- Should not be asked for passwordThe reason this popped up in automation for test_dvp_download_logs_empty_user but not test_dvp_upload_empty_user is simply that I had decorated the latter with 'associated_bug("PYT-429")', but not the former

[fdrozdowski]

➤ Zachary Burke commented:

Discarded as this no longer seems to happen

[fdrozdowski]

➤ Zachary Burke commented:

Reopened as I reproduced this with 1.0.0-internal-020 !Screen Shot 2019-07-28 at 1.36.11 PM.png|thumbnail!

I'm now seeing this again on 2.1.0: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/50231/consoleFull