Environment wrapper class should have a method for toolkit writers to get environment from reference

[fdrozdowski]

Currently the toolkit writer has to do something like:

env = RemoteEnvironment("name",
                  virtual_source.parameters.additional_mounts[0]["environment"],
                  RemoteHost("name","ref","bin_path","scratch_path"))

All of those values are then thrown away except for the environment ref. it would be good for the wrapper classes to have a function that the toolkit writers can use which only  needs an environment reference.

┆Issue is synchronized with this Jira Story by Unito

[fdrozdowski]

➤ Tom Walsh commented:

Two possible solutions come to mind:

1. For each of these plugin-constructable wrapper classes, provide a fromReference classmethod which accepts a reference and returns a newly-constructed object that "wraps" the reference. Not all of the fields of the object will be filled in, but that should be no problem.

myEnv = RemoteEnvironment.fromReference(virtual_source.parameters.additional_mounts[0]["environment"])2) Simply stop requiring the plugin to provide the user field at construction time. This field is never used, and actually it is impossible for the plugin to provide a real value here. The best the user can do is create a user object filled with dummy values.

myEnv = RemoteEnvironment("name",
virtual_source.parameters.additional_mounts[0]["environment"])