fix(http): allow HEAD method in file-server #6752
Open
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistency where
serveFile()
supported HEAD requests butserveDir()
returned 405 Method Not Allowed.Problem
serveFile()
correctly handles HEAD requests (returns headers without body)serveDir()
rejects HEAD requests with 405 Method Not AllowedSolution
serveDir()
to allow HEAD requests alongside GETserveFile()
which already has correct implementationChanges
http/file_server.ts
: Allow HEAD method in serveDir validationhttp/file_server_test.ts
: Add tests for serveDirHeadRequest scenariosTest Plan
serveDirHeadRequest
andserveDirHeadRequestForDirectoryWithIndex
Fixes #6750