feat: add md5 calculation for package uploads (#865)

* fix: refactor Jamf Protect functions

* feat: add MD5 hash calculation for package uploads

Author: neilmartin83

sdk/jamfpro/shared_helpers.go

@@ -4,6 +4,7 @@
 package jamfpro
 
 import (
+	"crypto/md5"
 	"encoding/hex"
 	"fmt"
 	"io"
@@ -63,3 +64,19 @@ func CalculateSHA3_512(filePath string) (string, error) {
 
 	return hex.EncodeToString(hash.Sum(nil)), nil
 }
+
+// CalculateMD5 calculates the MD5 hash of the supplied file in the path.
+func CalculateMD5(filePath string) (string, error) {
+	file, err := os.Open(filePath)
+	if err != nil {
+		return "", fmt.Errorf("failed to open file for MD5 calculation: %v", err)
+	}
+	defer file.Close()
+
+	hash := md5.New()
+	if _, err := io.Copy(hash, file); err != nil {
+		return "", fmt.Errorf("failed to calculate MD5: %v", err)
+	}
+
+	return hex.EncodeToString(hash.Sum(nil)), nil
+}

sdk/jamfpro/util_package_uploader.go

@@ -15,10 +15,11 @@ and verifies the uploaded package’s SHA3_512 hash.
 
 Steps:
 1. Calculate the SHA3_512 of the local file before uploading (initialHash).
-2. Create package metadata in Jamf Pro (Package name, etc.).
-3. Upload the actual file to Jamf Pro.
-4. Poll Jamf Pro until the uploaded package’s SHA3_512 hash is present or until max retries are reached.
-5. Compare Jamf Pro’s hash with the initially calculated hash to ensure data integrity.
+2. Calculate the MD5 hash of the file for metadata.
+3. Create package metadata in Jamf Pro (Package name, etc.).
+4. Upload the actual file to Jamf Pro.
+5. Poll Jamf Pro until the uploaded package’s SHA3_512 hash is present or until max retries are reached.
+6. Compare Jamf Pro’s hash with the initially calculated hash to ensure data integrity.
 
 Arguments:
 - filePath: The path to the local package file to be uploaded.
@@ -34,13 +35,20 @@ Usage:
 - Call DoPackageUpload with the path of your package and that resource data.
 */
 func (c *Client) DoPackageUpload(filePath string, packageData *ResourcePackage) (*ResponsePackageCreatedAndUpdated, error) {
+	pkgName := filepath.Base(filePath)
+
 	initialHash, err := CalculateSHA3_512(filePath)
 	if err != nil {
 		return nil, fmt.Errorf("failed to calculate initial SHA3_512: %v", err)
 	}
 
-	pkgName := filepath.Base(filePath)
+	md5Hash, err := CalculateMD5(filePath)
+	if err != nil {
+		return nil, fmt.Errorf("failed to calculate MD5: %v", err)
+	}
+
 	packageData.FileName = pkgName
+	packageData.MD5 = md5Hash
 	metadataResponse, err := c.CreatePackage(*packageData)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create package metadata in Jamf Pro: %v", err)