Skip to content

Commit eadef4b

Browse files
authored
[WALWAL-167] Mission Response 및 API PathVariable 수정 (#91)
* fix: Mission Response 및 API PathVariable 수정 * fix: MissionController Test 수정
1 parent af5d5e9 commit eadef4b

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

src/main/java/com/depromeet/stonebed/domain/mission/domain/Mission.java

-3
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ public class Mission extends BaseTimeEntity {
2727
@Column(name = "illustration_url")
2828
private String illustrationUrl;
2929

30-
@Column(name = "hex_color")
31-
private String hexColor;
32-
3330
@Builder
3431
public Mission(String title) {
3532
this.title = title;

src/main/java/com/depromeet/stonebed/domain/mission/dto/response/MissionGetTodayResponse.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,11 @@ public record MissionGetTodayResponse(
99
@Schema(description = "미션 제목", example = "산책하기")
1010
@NotBlank(message = "Title cannot be blank")
1111
String title,
12-
@Schema(description = "일러스트 이미지 URL", example = "https://example.com/image.jpeg")
13-
String illustrationUrl,
14-
@Schema(description = "Hex 색상 값", example = "#FFFFFF") String hexColor) {
12+
@Schema(description = "일러스트 이미지 URL", example = "https://image.walwal.life/image.jpeg")
13+
String illustrationUrl) {
1514

1615
public static MissionGetTodayResponse from(Mission mission) {
1716
return new MissionGetTodayResponse(
18-
mission.getId(),
19-
mission.getTitle(),
20-
mission.getIllustrationUrl(),
21-
mission.getHexColor());
17+
mission.getId(), mission.getTitle(), mission.getIllustrationUrl());
2218
}
2319
}

src/main/java/com/depromeet/stonebed/domain/missionRecord/api/MissionRecordController.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public ResponseEntity<Void> startMission(@PathVariable("missionId") Long mission
3333
}
3434

3535
@Operation(summary = "미션 기록 저장", description = "미션 완료 후 기록을 저장한다.")
36-
@PostMapping
36+
@PostMapping("/{missionId}")
3737
public ResponseEntity<Void> saveMission(@PathVariable("missionId") Long missionId) {
3838
missionRecordService.saveMission(missionId);
3939
return ResponseEntity.ok().build();

src/test/java/com/depromeet/stonebed/domain/mission/api/MissionControllerTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ public void setUp() {
6060
public void 오늘의_미션_조회_성공() throws Exception {
6161
// Given
6262
MissionGetTodayResponse missionGetTodayResponse =
63-
new MissionGetTodayResponse(
64-
1L, "Test Mission", "https://example.com/image.png", "#FFFFFF");
63+
new MissionGetTodayResponse(1L, "Test Mission", "https://example.com/image.png");
6564
when(missionService.getOrCreateTodayMission()).thenReturn(missionGetTodayResponse);
6665

6766
// When & Then

0 commit comments

Comments
 (0)