refactor: update methods to new method of storing preferences

Author: izolate

package.json

@@ -30,6 +30,7 @@
     "moment": "^2.17.1",
     "phpurlencode": "^1.0.0",
     "qs": "^6.3.0",
+    "ramda": "^0.23.0",
     "rndm": "^1.2.0",
     "url": "^0.11.0"
   },

src/resources/account/Preferences.js

@@ -1,51 +1,71 @@
 import DeskbookersError from '../../DeskbookersError'
 import Resource from '../Resource'
+import { pickAll } from 'ramda'
+
+// Construct and return Map
+function constructMap (obj) {
+  const map = new Map()
+
+  for (const key in obj) {
+    map.set(key, obj[key])
+  }
+
+  return map
+}
 
 export default class Preferences extends Resource {
   constructor (api) {
     super(api)
     this.endpoint = 'user/preferences'
   }
 
-  async retrieve (key) {
-    const value = await this.request({
+  async getCurrentPreferences () {
+    const res = await this.request({
       method: 'GET',
-      path: this.endpoint,
-      params: {
-        keys: [key]
-      }
+      path: this.endpoint
     })
 
-    return value[0]
+    return JSON.parse(res)
+  }
+
+  /**
+   * Retrieve a single preference
+   */
+  async retrieve (key) {
+    const prefs = await this.list([key])
+    return prefs.get(key) || null
   }
 
+  /**
+   * List all preferences, or a subset
+   */
   async list (...keys) {
-    const preferences = await this.request({
-      method: 'GET',
-      path: this.endpoint,
-      params: {
-        keys
-      }
-    })
+    const current = await this.getCurrentPreferences()
+
+    // Filter preferences based on desired keys
+    const prefs = keys.length ? pickAll(keys, current): current
 
-    // Construct and return Map
-    const map = new Map()
-    keys.forEach((key, i) => map.set(key, preferences[i]))
-    return map
+    return constructMap(prefs)
   }
 
+  /**
+   * Update preferences by key
+   */
   async update (preferences = {}) {
-    const prefs = await this.request({
+    const prefs = await this.getCurrentPreferences()
+
+    for (const key in preferences) {
+      prefs[key] = preferences[key]
+    }
+
+    const res = await this.request({
       method: 'POST',
       path: this.endpoint,
       params: {
-        preferences
+        preferences: prefs
       }
     })
 
-    // Construct and return Map
-    const map = new Map()
-    Object.keys(prefs).forEach(key => map.set(key, prefs[key]))
-    return map
+    return constructMap(JSON.parse(res))
   }
 }

yarn.lock

@@ -2687,6 +2687,10 @@ [email protected]:
   version "0.2.0"
   resolved "https://registry.yarnpkg.com/querystring/-/querystring-0.2.0.tgz#b209849203bb25df820da756e747005878521620"
 
+ramda@^0.23.0:
+  version "0.23.0"
+  resolved "https://registry.yarnpkg.com/ramda/-/ramda-0.23.0.tgz#ccd13fff73497a93974e3e86327bfd87bd6e8e2b"
+
 randomatic@^1.1.3:
   version "1.1.6"
   resolved "https://registry.yarnpkg.com/randomatic/-/randomatic-1.1.6.tgz#110dcabff397e9dcff7c0789ccc0a49adf1ec5bb"