Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment anything button #16

Open
Rub21 opened this issue Jul 7, 2023 · 1 comment
Open

Segment anything button #16

Rub21 opened this issue Jul 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Rub21
Copy link
Collaborator

Rub21 commented Jul 7, 2023

From: #13 (review)

Move the Segment Anything button to the sidebar and use a switch component instead, as it's just something to enable/disable a feature,

Sound good to move the button to the sidebar. If we employ a switch component, we'll have to decide how it behaves when activated. Should enabling the switch trigger a request to decode the view every time the map is clicked, or would it be better to have a separate button that sends the request only once when the switch component is turned on?

Currently, the app works as follows: if the site has cached an encoded image of the present map view, every click prompts a decode request. However, if there is no cached image, users still need to press the 'Segment Anything' button to encode the current map view. It's something we might want to reconsider as we make these changes.

cc. @willemarcel @rbavery

@Rub21 Rub21 added the enhancement New feature or request label Jul 7, 2023
@willemarcel
Copy link
Contributor

I think this is solved now that we have the New AOI button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants