Skip to content

Minor enhancement to avoid null exceptions. #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kzu opened this issue Feb 18, 2025 · 7 comments · May be fixed by #1542
Open

Minor enhancement to avoid null exceptions. #1533

kzu opened this issue Feb 18, 2025 · 7 comments · May be fixed by #1542

Comments

@kzu
Copy link
Member

kzu commented Feb 18, 2025

Discussed in #1529

Originally posted by iPazooki February 6, 2025
In the AwaitableFactory.cs file, the TryGet method may return null, which is not considered good practice. To address this issue and prevent potential null reference exceptions, I recommend changing the return type to IAwaitableFactory?. This indicates that the return value can be nullable, alerting developers that they need to handle this scenario appropriately. Subsequently, we need to change five more places because of this change which is not a big deal.

Back this issue
Back this issue

@ndwpatrick
Copy link

Hi @kzu I'm interested in working on this issue. Can I take it? Also, could you provide any additional details if needed?

@kzu
Copy link
Member Author

kzu commented Mar 7, 2025

Hi @ndwpatrick. Help is very much appreciated!

@ndwpatrick
Copy link

@kzu Can you please assign this issue to me so that I can start working on it.

@kzu kzu assigned kzu and ndwpatrick and unassigned kzu Mar 10, 2025
@kzu
Copy link
Member Author

kzu commented Mar 10, 2025

Done!

@ShirAvneri
Copy link

Hi @ndwpatrick , are you working on this issue?
Can I maybe take over?

@ShirAvneri
Copy link

Hi @kzu , it seems this issue is not being worked on.
Could I take over?

@kzu
Copy link
Member Author

kzu commented May 10, 2025

Sure thing! Assigning to you

@ShirAvneri ShirAvneri linked a pull request May 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants