-
-
Notifications
You must be signed in to change notification settings - Fork 818
Minor enhancement to avoid null exceptions. #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @kzu I'm interested in working on this issue. Can I take it? Also, could you provide any additional details if needed? |
Hi @ndwpatrick. Help is very much appreciated! |
@kzu Can you please assign this issue to me so that I can start working on it. |
Done! |
Hi @ndwpatrick , are you working on this issue? |
Hi @kzu , it seems this issue is not being worked on. |
Sure thing! Assigning to you |
Uh oh!
There was an error while loading. Please reload this page.
Discussed in #1529
Originally posted by iPazooki February 6, 2025
In the AwaitableFactory.cs file, the
TryGet
method may returnnull
, which is not considered good practice. To address this issue and prevent potential null reference exceptions, I recommend changing the return type toIAwaitableFactory?
. This indicates that the return value can be nullable, alerting developers that they need to handle this scenario appropriately. Subsequently, we need to change five more places because of this change which is not a big deal.The text was updated successfully, but these errors were encountered: