Skip to content

UpdateUrls workflow timeout not working #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hohwille opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1127
Open

UpdateUrls workflow timeout not working #690

hohwille opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1127
Assignees
@jan-vcapgemini
Labels
bug Something isn't working SCM software-configuration-management (github actions, internal processes, git or github utilization) urls ide-urls repo and related processes and features

Comments

@hohwille
Copy link
Member

Expected behavior

As a IDEasy product owner, I want to have a reliable process for UpdateURLs so that we do not get stuck.
Therefore we had issue devonfw/ide#1162 implemented via PR https://github.com/devonfw/ide/pull/1203/files.
However this is not working properly.

Actual behavior

IDEasy/.github/workflows/update-urls.yml

Line 30 in 51a16e1

mvn -B -ntp -Dstyle.color=always exec:java -Dexec.mainClass="com.devonfw.tools.ide.url.UpdateInitiator" -Dexec.args="../ide-urls PT5H30M"

So the action should start timeout after 5:30 (PT5H30M) but it is not working:
grafik

Steps to reproduce (bug) / Use Case of feature request (enhancement)

  1. have a look at the screenshot or https://github.com/devonfw/IDEasy/actions/runs/11292746585/job/31409367488

Related/Dependent Issues

See devonfw-ide issue and PR linked above.

Comments/Hints:

Currently we have the timeout check in these places:

It seems for some reason that is not sufficient.
IMHO it is at least missing here:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java

Line 741 in 51a16e1

UrlVersion urlVersion = edition.getChild(version);

@hohwille hohwille added bug Something isn't working urls ide-urls repo and related processes and features SCM software-configuration-management (github actions, internal processes, git or github utilization) labels Oct 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Oct 11, 2024
@hj-lorenz hj-lorenz moved this from 🆕 New to 🏗 In progress in IDEasy board Mar 4, 2025
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Mar 11, 2025
@hj-lorenz
devonfw#690: Excluded .github and .yml from ignoring
56e10e2
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Mar 11, 2025
@hj-lorenz
devonfw#690: POC for dynamic and parallel update of URLs
8b3ea09
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Mar 11, 2025
@hj-lorenz
devonfw#690: Removed not necessary info log.
7584d71
@jan-vcapgemini jan-vcapgemini linked a pull request Mar 13, 2025 that will close this issue
Draft
@hohwille hohwille linked a pull request May 12, 2025 that will close this issue
#690: update urls workflow timeout not working #1127
Draft
@hohwille
Copy link
Member Author

In general the idea of PR #1127 is nice but way more complicated and therefore it is not completed.
Currently the problem is not affecting us but when it comes back, we should at least implement my suggested solution idea to get this done.

@hohwille hohwille moved this from 🏗 In progress to Research in IDEasy board May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-vcapgemini jan-vcapgemini

Labels
bug Something isn't working SCM software-configuration-management (github actions, internal processes, git or github utilization) urls ide-urls repo and related processes and features
Projects
IDEasy board
Status: Research
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#690: update urls workflow timeout not working hj-lorenz/IDEasy
3 participants
@hohwille @jan-vcapgemini @hj-lorenz