Treat Creation of CountdownLatch With Negative Value as Die Failure (zio#7625)

* die

* fix test

Author: adamgfraser

concurrent/shared/src/main/scala/zio/concurrent/CountdownLatch.scala

@@ -47,10 +47,9 @@ final class CountdownLatch private (_count: Ref[Int], _waiters: Promise[Nothing,
 }
 
 object CountdownLatch {
-  def make(n: Int): IO[Option[Nothing], CountdownLatch] =
+  def make(n: Int): UIO[CountdownLatch] =
     if (n <= 0)
-      // People calling this with a negative value deserve this
-      ZIO.none.flip
+      ZIO.die(new IllegalArgumentException("n must be positive"))
     else
       Ref.make(n).zipWith(Promise.make[Nothing, Unit])(new CountdownLatch(_, _))
 }

concurrent/shared/src/test/scala/zio/concurrent/CountdownLatchSpec.scala

@@ -11,8 +11,8 @@ object CountdownLatchSpec extends ZIOSpecDefault {
         test("Creates a latch") {
           assertZIO(CountdownLatch.make(100).flatMap(_.count).exit)(succeeds(equalTo(100)))
         },
-        test("Fails with an invalid count") {
-          assertZIO(CountdownLatch.make(0).exit)(fails(equalTo(None)))
+        test("Dies with an invalid count") {
+          assertZIO(CountdownLatch.make(0).exit)(dies(anything))
         }
       ),
       suite("Operations")(