feat: make argocd uninstall operation idempotent

Signed-off-by: Daniel Hu <[email protected]>

Author: daniel-hutao

Makefile

@@ -12,7 +12,7 @@ build-core: fmt vet ## Build dtm core only, locally.
 	go mod tidy
 	go build -trimpath -gcflags="all=-N -l" -o dtm ./cmd/devstream/
 
-fmt: ## Run go fmt against code.
+fmt: ## Run 'go fmt' & goimports against code.
 	go get golang.org/x/tools/cmd/goimports
 	goimports -local="github.com/merico-dev/stream" -d -w cmd
 	goimports -local="github.com/merico-dev/stream" -d -w internal

internal/pkg/argocd/argocd.go

@@ -3,6 +3,7 @@ package argocd
 import (
 	"context"
 	"log"
+	"strings"
 	"time"
 
 	"github.com/mitchellh/mapstructure"
@@ -75,6 +76,22 @@ func (a *ArgoCD) installOrUpgradeHelmChart() error {
 	return nil
 }
 
+// uninstallHelmChartIgnoreReleaseNotFound will return nil when:
+// 1. The argocd helm chart release uninstall successful
+// 2. The argocd helm chart release not found
+func (a *ArgoCD) uninstallHelmChartIgnoreReleaseNotFound() error {
+	err := a.uninstallHelmChart()
+	// Log: < Release not loaded: argocd: release: not found >
+	if err == nil {
+		return nil
+	}
+	if strings.Contains(err.Error(), "not found") {
+		log.Println("argocd release is not found, maybe it has been deleted")
+		return nil
+	}
+	return err
+}
+
 func (a *ArgoCD) uninstallHelmChart() error {
 	err := (*a.client).UninstallReleaseByName(a.param.Chart.ReleaseName)
 	if err != nil {

internal/pkg/argocd/reinstall.go

@@ -11,7 +11,7 @@ func Reinstall(options *map[string]interface{}) (bool, error) {
 	}
 
 	log.Println("uninstalling argocd helm chart")
-	if err := acd.uninstallHelmChart(); err != nil {
+	if err := acd.uninstallHelmChartIgnoreReleaseNotFound(); err != nil {
 		return false, err
 	}
 

internal/pkg/argocd/uninstall.go

@@ -11,7 +11,7 @@ func Uninstall(options *map[string]interface{}) (bool, error) {
 	}
 
 	log.Println("uninstalling argocd helm chart")
-	if err := acd.uninstallHelmChart(); err != nil {
+	if err := acd.uninstallHelmChartIgnoreReleaseNotFound(); err != nil {
 		return false, err
 	}
 

internal/pkg/statemanager/state.go

@@ -15,9 +15,9 @@ const (
 	StatusUninstalled ComponentStatus = "uninstalled"
 	// We use StatusInstalled when a plugin is installed but we don't know its status is "running" or "failed".
 	// For example: We try to uninstall a plugin but failed for some reason.
-	StatusInstalled   ComponentStatus = "installed"
-	StatusRunning     ComponentStatus = "running"
-	StatusFailed      ComponentStatus = "failed"
+	StatusInstalled ComponentStatus = "installed"
+	StatusRunning   ComponentStatus = "running"
+	StatusFailed    ComponentStatus = "failed"
 )
 
 const (