Skip to content

Commit cacf5ad

Browse files
authored
Fix: helm-style plugins Read() don't return the state with ready workflows (#234)
Signed-off-by: Daniel Hu <[email protected]>
1 parent ecdc6f9 commit cacf5ad

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

internal/pkg/plugin/jenkins/read.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,6 @@ func readStatefulsets(kubeClient *k8s.Client, namespace, releaseName string, sta
6060
}
6161

6262
for _, ss := range sss {
63-
if kubeClient.IsStatefulsetReady(&ss) {
64-
log.Infof("The statefulset %s is ready.", ss.Name)
65-
continue
66-
}
67-
log.Warnf("The statefulset %s is not ready.", ss.Name)
68-
6963
DefaultStatefulsetList := GetDefaultStatefulsetList(releaseName)
7064
ssName := ss.GetName()
7165
if !slices.Contains(DefaultStatefulsetList, ssName) {

internal/pkg/plugin/kubeprometheus/read.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ func readDeployments(kubeClient *k8s.Client, namespace, releaseName string, stat
7070
}
7171

7272
for _, dp := range dps {
73-
if kubeClient.IsDeploymentReady(&dp) {
74-
log.Infof("The deployment %s is ready.", dp.Name)
75-
continue
76-
}
77-
log.Warnf("The deployment %s is not ready.", dp.Name)
78-
7973
DefaultDeploymentList := GetDefaultDeploymentList(releaseName)
8074
dpName := dp.GetName()
8175
if !slices.Contains(DefaultDeploymentList, dpName) {
@@ -98,12 +92,6 @@ func readDaemonsets(kubeClient *k8s.Client, namespace, releaseName string, state
9892
}
9993

10094
for _, ds := range dss {
101-
if kubeClient.IsDaemonsetReady(&ds) {
102-
log.Infof("The daemonset %s is ready.", ds.Name)
103-
continue
104-
}
105-
log.Warnf("The daemonset %s is not ready.", ds.Name)
106-
10795
DefaultDaemonsetList := GetDefaultDaemonsetList(releaseName)
10896
dsName := ds.GetName()
10997
if !slices.Contains(DefaultDaemonsetList, dsName) {
@@ -126,12 +114,6 @@ func readStatefulsets(kubeClient *k8s.Client, namespace, releaseName string, sta
126114
}
127115

128116
for _, ss := range sss {
129-
if kubeClient.IsStatefulsetReady(&ss) {
130-
log.Infof("The statefulset %s is ready.", ss.Name)
131-
continue
132-
}
133-
log.Warnf("The statefulset %s is not ready.", ss.Name)
134-
135117
DefaultStatefulsetList := GetDefaultStatefulsetList(releaseName)
136118
ssName := ss.GetName()
137119
if !slices.Contains(DefaultStatefulsetList, ssName) {

0 commit comments

Comments
 (0)