-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error after not finding pre-training models (ir.dill) #21
Comments
Hi Ivan, Were you ever able to figure it out? I am also having issues with my CellO resources directory. Thanks! |
My apologies for the trouble. I just fixed the bug. If you re-install CellO via |
I'm getting the same error. I downloaded the resources and unpacked with:
which gives me the following output:
and the following files:
I installed cello-classify v 2.1.1 in my conda env with pip:
|
Circling back to this issue as I hit it too today. I was able to get around it but in a rather dumb way. So the curl command don't respect the assignment of the cello_resource_loc and even if you set them those commands can't find the dir and will default to try and download the resource dir in the current dir. Then the tar command tries to unpack the archive in the cello_resource_loc rather than the current dir and can't find it and the script errors out. Here is how I was able to get around this issue.
|
Looks like this is the issue from the cello.py file
The rsrc_loc is I believe the dir where the resource folder lives or at least thats what the rest of the script uses it as but the download.py function you define should treat this as the cello_resource_loc which is not the actuall cell_resource_loc but really the working dir or at least that is how users are using it often, and then hit this issue. The function works but only if you run things in the current dir the first time you run the pipeline and then set the resource dir that is made to the cello_resource_loc every time after. As I type this and read it that makes sense to name the cello_resource_location to the location of the resource dir but first-time users will find this confusing when looking at the documentation. Also you kinda set users up for a hard time because they will never have the resource dir untill after they run the pipeline the first time and unless the run it in the current dir it will crash out. If I have time I can rewrite stuff and make a pull request to change download and the scanpy_cello to take a new imput which would be the "work dir" which people are right now setting the cello_resource_dir to. However that likley will throw other errors and might be a pain because you use the rsrc_loc for so much stuff when you train the local model, so users would likely still be confused about what to set the cello_resource_dir to. The more easy thing would be to change nothing and just update the documentation to explicitly tell people the first time they run this they have to run it in the local dir and then set the cell_resource_loc the resource dir in the future. Or if all else fails kindly point people to the start protocol paper you guys put out. for more information on the resource dir they will be downloading. |
Fixed issue deweylab#21 with not being able to download resource dir for first-time users
Fixed deweylab#21 with not being able to download resource dir for first-time users
Hello everyone.
I just installed the latest cello-classify version with pip. Version 2.0.3. Installation went fine.
When I try to use it, I get an error.
I execute this cell in a JupyterLab notebook:
and this is the error:
Could somebody offer some guidance?
Thank you.
Ivan
The text was updated successfully, but these errors were encountered: