Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authproxy connector: add support for specifying group header separator #3999

Open
2 tasks done
a-buck opened this issue Feb 20, 2025 · 0 comments
Open
2 tasks done

authproxy connector: add support for specifying group header separator #3999

a-buck opened this issue Feb 20, 2025 · 0 comments

Comments

@a-buck
Copy link

a-buck commented Feb 20, 2025

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

This issue proposes making the group header splitter configurable so a value other than , can be used.

This is motivated as the groups header is not universally a ,. For example the default group separator in mod_auth_mellon is ;.

To give a very specific example of how it would be useful, this would enable use of the dex integration for SSO in argocd, where the groups are not separated with a comma.

# https://argo-cd.readthedocs.io/en/stable/operator-manual/user-management/#dex

argo-cd:
  dex:
    enabled: true

  configs:
    cm:
      dex.config: |
        connectors:
        - type: authproxy
          id: corpproxy
          name: corpproxy
          config:
            userHeader: SSO-User
            groupHeader: SSO-Groups
            groupHeaderSeparator: ";"

Proposed Solution

  • groupHeaderSeparator is added as a configurable option for the authproxy connector
  • the change is backwards compatible - maintaining , as a default

Alternatives Considered

No response

Additional Information

please see #3745 for example implementation, happy to revive the PR if there is feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant