chore: new fields for uninstalling code while taking canister snapshot (#7855)

This PR adds two extra fields to the input type of the
`take_canister_snapshot` method of the management canister:
- `uninstall_code`: allows to atomically uninstall the canister after
taking its snapshot; in particular, the canister memory usage is updated
atomically and thus it does not grow significantly (ignoring some
potential constant overhead for certified variables which are not
accounted for by canister memory usage, but are accounted for in
canister snapshot memory usage),
- `sender_canister_version`: needed to record the sender canister
version in the code uninstallation entry in canister history.

Warning! The actual functionality will only be implemented in follow-up
PRs.

Author: mraszyk

rs/execution_environment/benches/management_canister/canister_snapshots.rs

@@ -48,7 +48,7 @@ fn env_and_canister(canister_size: u64) -> (StateMachine, CanisterId) {
 fn env_and_canister_snapshot(canister_size: u64) -> (StateMachine, CanisterId, SnapshotId) {
     let (env, canister_id) = env_and_canister(canister_size);
     let snapshot_id = env
-        .take_canister_snapshot(TakeCanisterSnapshotArgs::new(canister_id, None))
+        .take_canister_snapshot(TakeCanisterSnapshotArgs::new(canister_id, None, None, None))
         .expect("Error taking canister snapshot")
         .snapshot_id();
     (env, canister_id, snapshot_id)
@@ -124,8 +124,13 @@ fn take_canister_snapshot_bench<M: criterion::measurement::Measurement>(
         b.iter_batched(
             || env_and_canister(canister_size),
             |(env, canister_id)| {
-                env.take_canister_snapshot(TakeCanisterSnapshotArgs::new(canister_id, None))
-                    .expect("Error taking canister snapshot");
+                env.take_canister_snapshot(TakeCanisterSnapshotArgs::new(
+                    canister_id,
+                    None,
+                    None,
+                    None,
+                ))
+                .expect("Error taking canister snapshot");
                 env
             },
             BatchSize::SmallInput,
@@ -135,8 +140,13 @@ fn take_canister_snapshot_bench<M: criterion::measurement::Measurement>(
         b.iter_batched(
             || env_and_canister(canister_size),
             |(env, canister_id)| {
-                env.take_canister_snapshot(TakeCanisterSnapshotArgs::new(canister_id, None))
-                    .expect("Error taking canister snapshot");
+                env.take_canister_snapshot(TakeCanisterSnapshotArgs::new(
+                    canister_id,
+                    None,
+                    None,
+                    None,
+                ))
+                .expect("Error taking canister snapshot");
                 env.checkpointed_tick();
                 env
             },
@@ -157,6 +167,8 @@ fn replace_canister_snapshot_bench<M: criterion::measurement::Measurement>(
                 env.take_canister_snapshot(TakeCanisterSnapshotArgs::new(
                     canister_id,
                     Some(snapshot_id),
+                    None,
+                    None,
                 ))
                 .expect("Error replacing canister snapshot");
                 env
@@ -171,6 +183,8 @@ fn replace_canister_snapshot_bench<M: criterion::measurement::Measurement>(
                 env.take_canister_snapshot(TakeCanisterSnapshotArgs::new(
                     canister_id,
                     Some(snapshot_id),
+                    None,
+                    None,
                 ))
                 .expect("Error replacing canister snapshot");
                 env.checkpointed_tick();

rs/execution_environment/src/canister_manager/tests.rs

@@ -1909,7 +1909,7 @@ fn delete_canister_updates_subnet_available_memory_for_memory_allocation(memory_
     .unwrap();
 
     // Take canister snapshot => ~1 GiB of snapshot memory.
-    let take_canister_snapshot_args = TakeCanisterSnapshotArgs::new(canister_id, None);
+    let take_canister_snapshot_args = TakeCanisterSnapshotArgs::new(canister_id, None, None, None);
     test.subnet_message(
         Method::TakeCanisterSnapshot,
         take_canister_snapshot_args.encode(),
@@ -6724,6 +6724,8 @@ fn cannot_rename_with_snapshots() {
     env2.take_canister_snapshot(TakeCanisterSnapshotArgs {
         canister_id: canister_id2.into(),
         replace_snapshot: None,
+        uninstall_code: None,
+        sender_canister_version: None,
     })
     .unwrap();
 

rs/execution_environment/src/execution_environment/tests.rs

@@ -1049,6 +1049,8 @@ fn get_canister_status_memory_metrics_snapshots_size() {
         TakeCanisterSnapshotArgs {
             canister_id: canister_id.into(),
             replace_snapshot: None,
+            uninstall_code: None,
+            sender_canister_version: None,
         }
         .encode(),
     )
@@ -1699,15 +1701,17 @@ fn canister_snapshots_after_split() {
     );
 
     // Take canister snapshot for each canister.
-    let args: TakeCanisterSnapshotArgs = TakeCanisterSnapshotArgs::new(canister_id_1, None);
+    let args: TakeCanisterSnapshotArgs =
+        TakeCanisterSnapshotArgs::new(canister_id_1, None, None, None);
     test.inject_call_to_ic00(
         Method::TakeCanisterSnapshot,
         Encode!(&args).unwrap(),
         Cycles::new(1_000_000_000),
     );
     test.execute_subnet_message();
 
-    let args: TakeCanisterSnapshotArgs = TakeCanisterSnapshotArgs::new(canister_id_2, None);
+    let args: TakeCanisterSnapshotArgs =
+        TakeCanisterSnapshotArgs::new(canister_id_2, None, None, None);
     test.inject_call_to_ic00(
         Method::TakeCanisterSnapshot,
         Encode!(&args).unwrap(),