feat(ICRC_Ledger): DEFI-2541: Manual Block deserializer implementation #7847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Follow-up PR: PR 7848. |
Comment on lines
90
to
96
| TransferBuilder { | ||
| builder: self, | ||
| from, | ||
| to, | ||
| amount, | ||
| spender: Some(spender), | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| TransferBuilder { | |
| builder: self, | |
| from, | |
| to, | |
| amount, | |
| spender: Some(spender), | |
| } | |
| self.transfer(from, to, amount).spender(spender) |
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this! I removed the transfer_from helper method completely, since as you pointed out, we have the transfer to which you can add spender for accomplishing the same thing.
maciejdfinity
previously approved these changes
Dec 2, 2025
maciejdfinity
approved these changes
Dec 3, 2025
Contributor
maciejdfinity
left a comment
maciejdfinity
left a comment
There was a problem hiding this comment.
As discussed, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparation for supporting the parsing of blocks that have no
tx.opfield in the ICRC-3 block, this PR proposes to manually implement theDeserializetrait forBlock. Internally, the deserialization implementation then uses both thebtypeof theBlock, as well as the parsedFlattenedTransaction, to parse theTransactionthat is subsequently used e.g., by the index to apply the transaction in the block.