Remove A/B testing code for registration flow (#3386)

Author: lmuntaner

src/frontend/src/lib/components/wizards/auth/AuthWizard.svelte

@@ -7,7 +7,6 @@
   import Dialog from "$lib/components/ui/Dialog.svelte";
   import SetupOrUseExistingPasskey from "$lib/components/wizards/auth/views/SetupOrUseExistingPasskey.svelte";
   import CreatePasskey from "$lib/components/wizards/auth/views/CreatePasskey.svelte";
-  import InfoPasskey from "$lib/components/wizards/auth/views/InfoPasskey.svelte";
   import SystemOverlayBackdrop from "$lib/components/utils/SystemOverlayBackdrop.svelte";
   import { RegisterAccessMethodWizard } from "$lib/components/wizards/registerAccessMethod";
   import { canisterConfig } from "$lib/globals";
@@ -67,23 +66,7 @@
     isAuthenticating = true;
     try {
       const result = await authFlow.submitNameAndContinue(name);
-      if (result?.type === "created") {
-        onSignUp(result.identityNumber);
-      }
-    } catch (error) {
-      if (isWebAuthnCancelError(error)) {
-        return "cancelled";
-      }
-      onError(error); // Propagate unhandled errors to parent component
-    } finally {
-      isAuthenticating = false;
-    }
-  };
-
-  const handleContinueCreatePasskey = async (): Promise<void | "cancelled"> => {
-    isAuthenticating = true;
-    try {
-      onSignUp(await authFlow.createPasskey());
+      onSignUp(result.identityNumber);
     } catch (error) {
       if (isWebAuthnCancelError(error)) {
         return "cancelled";
@@ -160,16 +143,10 @@
   {:else if authFlow.view === "setupNewPasskey"}
     <CreatePasskey
       create={handleCreatePasskey}
-      buttonLabel={authFlow.abTestGroup === "infoPasskey"
-        ? "Continue"
-        : $AUTH_FLOW_UPDATES
-          ? "Create Identity"
-          : "Create Passkey"}
+      buttonLabel={$AUTH_FLOW_UPDATES ? "Create Identity" : "Create Passkey"}
     />
   {:else if authFlow.view === "setupNewIdentity"}
     <CreateIdentity create={handleCompleteOpenIdRegistration} />
-  {:else if authFlow.view === "infoPasskey"}
-    <InfoPasskey create={handleContinueCreatePasskey} />
   {/if}
 {/snippet}
 

src/frontend/src/lib/components/wizards/auth/views/InfoPasskey.svelte

@@ -44,7 +44,6 @@ export class AuthFlow {
     | "chooseMethod"
     | "setupOrUseExistingPasskey"
     | "setupNewPasskey"
-    | "infoPasskey"
     | "setupNewIdentity"
   >("chooseMethod");
   #captcha = $state<{
@@ -57,7 +56,6 @@ export class AuthFlow {
   #name = $state<string>();
   #jwt = $state<string>();
   #configIssuer = $state<string>();
-  abTestGroup: "infoPasskey" | "default";
 
   get view() {
     return this.#view;
@@ -77,32 +75,22 @@ export class AuthFlow {
 
   constructor() {
     this.chooseMethod();
-    const isE2E = nonNullish(canisterConfig.dummy_auth[0]?.[0]);
-    // No A/B test in E2E runs
-    const GROUP_INFO_PERCENTAGE = isE2E ? -1 : 0.2;
-    this.abTestGroup =
-      Math.random() < GROUP_INFO_PERCENTAGE ? "infoPasskey" : "default";
   }
 
   chooseMethod = (): void => {
-    authenticationV2Funnel.trigger(AuthenticationV2Events.SelectMethodScreen, {
-      abTestGroup: this.abTestGroup,
-    });
+    authenticationV2Funnel.trigger(AuthenticationV2Events.SelectMethodScreen);
     this.#view = "chooseMethod";
   };
 
   setupOrUseExistingPasskey = (): void => {
     authenticationV2Funnel.trigger(
       AuthenticationV2Events.ContinueWithPasskeyScreen,
-      { abTestGroup: this.abTestGroup },
     );
     this.#view = "setupOrUseExistingPasskey";
   };
 
   continueWithExistingPasskey = async (): Promise<bigint> => {
-    authenticationV2Funnel.trigger(AuthenticationV2Events.UseExistingPasskey, {
-      abTestGroup: this.abTestGroup,
-    });
+    authenticationV2Funnel.trigger(AuthenticationV2Events.UseExistingPasskey);
     const { identity, identityNumber, credentialId } =
       await authenticateWithPasskey({
         canisterId,
@@ -120,31 +108,20 @@ export class AuthFlow {
   };
 
   setupNewPasskey = (): void => {
-    authenticationV2Funnel.trigger(AuthenticationV2Events.EnterNameScreen, {
-      abTestGroup: this.abTestGroup,
-    });
+    authenticationV2Funnel.trigger(AuthenticationV2Events.EnterNameScreen);
     this.#view = "setupNewPasskey";
   };
 
   submitNameAndContinue = async (
     name: string,
-  ): Promise<undefined | { type: "created"; identityNumber: bigint }> => {
+  ): Promise<{ type: "created"; identityNumber: bigint }> => {
     this.#name = name;
-    if (this.abTestGroup === "infoPasskey") {
-      authenticationV2Funnel.trigger(AuthenticationV2Events.InfoPasskeyScreen, {
-        abTestGroup: this.abTestGroup,
-      });
-      this.#view = "infoPasskey";
-      return;
-    } else {
-      return { type: "created", identityNumber: await this.createPasskey() };
-    }
+    return { type: "created", identityNumber: await this.createPasskey() };
   };
 
   createPasskey = async (): Promise<bigint> => {
     authenticationV2Funnel.trigger(
       AuthenticationV2Events.StartWebauthnCreation,
-      { abTestGroup: this.abTestGroup },
     );
     if (isNullish(this.#name)) {
       throw new Error("Name is not set");
@@ -360,9 +337,7 @@ export class AuthFlow {
     passkeyIdentity: DiscoverablePasskeyIdentity,
     attempts = 0,
   ): Promise<bigint> => {
-    authenticationV2Funnel.trigger(AuthenticationV2Events.RegisterWithPasskey, {
-      abTestGroup: this.abTestGroup,
-    });
+    authenticationV2Funnel.trigger(AuthenticationV2Events.RegisterWithPasskey);
     const uaParser = loadUAParser();
     const alias = await inferPasskeyAlias({
       authenticatorType: passkeyIdentity.getAuthenticatorAttachment(),
@@ -387,7 +362,6 @@ export class AuthFlow {
         .then(throwCanisterError);
       authenticationV2Funnel.trigger(
         AuthenticationV2Events.SuccessfulPasskeyRegistration,
-        { abTestGroup: this.abTestGroup },
       );
       const credentialId = new Uint8Array(passkeyIdentity.getCredentialId()!);
       const identity = await authenticateWithSession({

src/frontend/src/lib/flows/authFlow.svelte.ts

@@ -28,7 +28,6 @@ import { Funnel } from "./Funnel";
  *          jwt-verification-expired
  *      continue-with-passkey-screen
  *        enter-name-screen
- *          [info-passkey-screen]
  *          start-webauthn-creation
  *            register-with-passkey
  *              successful-passkey-registration
@@ -57,7 +56,6 @@ export const AuthenticationV2Events = {
   AuthSuccess: "auth-success",
   JwtVerificationFailed: "jwt-verification-failed",
   JwtVerificationExpired: "jwt-verification-expired",
-  InfoPasskeyScreen: "info-passkey-screen",
   GoToDashboard: "go-to-dashboard",
 } as const;