You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some ingested resources provide concept IDs instead of, or in addition to, drug and gene names. We are relatively inconsistent about how we handle this, e.g. whether we make the label or the concept ID an alias.
I think it'd be preferable to parse out the concept ID when it's available. This would help grouping (better to search by concept ID first). If a claim doesn't provide a label otherwise, we could just copy the ID over to the label as well.
This becomes relevant in cases like this: #567. Here, an NCI row simply provides the drug name "ADM" and NCIt concept code "C1326". We store the name as the name of the claim and the concept code as an xref. This becomes problematic during normalization because "ADM" is ambiguous (acellular dermal matrix vs adriamycin).
Other possibilities:
Always make the concept ID the label if available. This would obviate the need for a schema change but I think it's less ideal if we want to make UI views for claims (which I think we should, this was a feature in the original UI if I'm not mistaken).
The text was updated successfully, but these errors were encountered:
As mentioned from our discussion, I think this is a good idea but we should probably do a test run of this just to see how it impacts grouping. Also, we should consider another name for this column besides concept_id so as to avoid confusion/differentiate it a little more. Maybe source_concept_id?
Some ingested resources provide concept IDs instead of, or in addition to, drug and gene names. We are relatively inconsistent about how we handle this, e.g. whether we make the label or the concept ID an alias.
I think it'd be preferable to parse out the concept ID when it's available. This would help grouping (better to search by concept ID first). If a claim doesn't provide a label otherwise, we could just copy the ID over to the label as well.
This becomes relevant in cases like this: #567. Here, an NCI row simply provides the drug name "ADM" and NCIt concept code "C1326". We store the name as the name of the claim and the concept code as an xref. This becomes problematic during normalization because "ADM" is ambiguous (acellular dermal matrix vs adriamycin).
Other possibilities:
The text was updated successfully, but these errors were encountered: