Skip to content

Commit 3067922

Browse files
ShivaShiva
authored andcommitted
Unskip previously skipped tests
1 parent d28f8fa commit 3067922

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

dgraph/cmd/dgraphimport/import_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const expectedSchema = `{
6363
}`
6464

6565
func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
66-
t.Skip("Skipping... sometimes the query for schema succeeds even when the server is in draining mode")
66+
// t.Skip("Skipping... sometimes the query for schema succeeds even when the server is in draining mode")
6767

6868
tests := []struct {
6969
name string
@@ -111,7 +111,7 @@ func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
111111
}
112112

113113
func TestImportApis(t *testing.T) {
114-
t.Skip("Skipping import tests due to persistent flakiness with container networking and Raft leadership issues")
114+
// t.Skip("Skipping import tests due to persistent flakiness with container networking and Raft leadership issues")
115115

116116
tests := []testcase{
117117
{
@@ -400,6 +400,7 @@ func verifyImportResults(t *testing.T, gc *dgraphapi.GrpcClient, downAlphas int)
400400
// Get actual predicates
401401
actualPredicates := getPredicateMap(actualSchema)
402402

403+
hasAllPredicates := true
403404
// Check if all expected predicates are present
404405
for predName := range expectedPredicates {
405406
if _, exists := actualPredicates[predName]; !exists {

dgraphtest/load.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -580,8 +580,8 @@ func downloadFile(fname, url string) error {
580580
cmd := exec.Command("wget", "-O", fname, url)
581581
cmd.Dir = datasetFilesPath
582582

583-
if out, err := cmd.CombinedOutput(); err != nil {
584-
return fmt.Errorf("error downloading file %s: %s", fname, string(out))
583+
if _, err := cmd.CombinedOutput(); err != nil {
584+
return fmt.Errorf("error downloading file %s: %w", fname, err)
585585
}
586586
return nil
587587
}

dgraphtest/local_cluster.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -930,8 +930,7 @@ func (c *LocalCluster) Client() (*dgraphapi.GrpcClient, func(), error) {
930930
var conns []*grpc.ClientConn
931931
for _, aa := range c.alphas {
932932
if !aa.isRunning {
933-
// QUESTIONS(shivaji): Should this be 'continue' instead of a break from the loop
934-
break
933+
continue
935934
}
936935
url, err := aa.alphaURL(c)
937936
if err != nil {

0 commit comments

Comments
 (0)