fix: not possible to see more or search for App items when creating d…

…ashboard (#3187)

Fixes DHIS2-18835

Fix: the Item selector list is populated based on the item type, but for some reason 
the code for setting which types should "Show more" was using itemType.id, which APP lacked.
Now, it will consistently check the type rather than id. But also, the id property for APP
was added to the itemTypes object, for code consistency.

src/modules/itemTypes.js

@@ -137,6 +137,7 @@ export const itemTypeMap = {
         appKey: 'line-listing',
     },
     [APP]: {
+        id: APP,
         endPointName: 'apps',
         propName: 'appKey',
         pluralTitle: i18n.t('Apps'),

src/pages/edit/ItemSelector/ItemSelector.js

@@ -59,7 +59,7 @@ const ItemSelector = () => {
                 const itemCount = getDefaultItemCount(type)
                 const allItems = items[itemType.endPointName]
                 const hasMore = allItems.length > itemCount
-                const displayItems = maxOptions.has(itemType.id)
+                const displayItems = maxOptions.has(type)
                     ? allItems
                     : allItems.slice(0, itemCount)