Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5] "Disable Crippling Shrines" should disable "Murphy's Shrine" #7740

Open
glebm opened this issue Feb 9, 2025 · 3 comments
Open

[1.5] "Disable Crippling Shrines" should disable "Murphy's Shrine" #7740

glebm opened this issue Feb 9, 2025 · 3 comments

Comments

@glebm
Copy link
Collaborator

glebm commented Feb 9, 2025

Murphy's Shrine - Causes a randomly chosen equipped item to lose 50% durability, or else takes away 1/3 of the gold in inventory

@kphoenix137
Copy link
Collaborator

I'm not sure I agree with this change. The Disable Crippling Shrines option is a way to prevent negative effects that have no way of being reversed.

@kphoenix137
Copy link
Collaborator

kphoenix137 commented Feb 9, 2025

Wait, doesn't it already?:

return IsAnyOf(static_cast<shrine_type>(_oVar1), shrine_type::ShrineFascinating, shrine_type::ShrineOrnate, shrine_type::ShrineSacred, shrine_type::ShrineMurphys);

I'm guessing the title was intended to say "shouldn't". In that case, fully agreed!

@kphoenix137
Copy link
Collaborator

I guess I misunderstood twice. The code implies it's disabled, but in game it appears not to be disabled.

@glebm glebm changed the title "Disable Crippling Shrines" should disable "Murphy's Shrine" [1.5] "Disable Crippling Shrines" should disable "Murphy's Shrine" Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants