Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue Report]: Item Morphing #7742

Open
indigorain opened this issue Feb 10, 2025 · 5 comments · May be fixed by #7743
Open

[Issue Report]: Item Morphing #7742

indigorain opened this issue Feb 10, 2025 · 5 comments · May be fixed by #7743

Comments

@indigorain
Copy link

indigorain commented Feb 10, 2025 •
edited
Loading

Operating System

Linux x64

DevilutionX version

Other (please specify version number)

Describe

Items that were shopped in Hellfire are morphing when brought into classic. This is only happening in the beta version (downloaded February 1st, 2025). This is in multiplayer.

Multiplayer Diablo 1.5.4

Image

Multiplayer Diablo 1.6.0-dev (2 Screenshots)

Image

Image

To Reproduce

Made a copy of my save in an external folder
Launched game using different versions
Loaded up character save to check if items morphed (and started a second game to double check if they would morph for 1.5.4 and lower)

I've attached my original hellfire save and also the classic version that I have been using. Cannot upload .sv or .hsv so I added .txt to these files.

multi_30.hsv.txt
multi_30.sv.txt

Expected Behavior

Items should never morph and instead be colored red to signify that they cannot be used.

Additional context

Image
@kphoenix137
Copy link
Collaborator

Can you label which screenshots are which? They would be any of these:

  • Multiplayer Diablo 1.5.4
  • Multiplayer Hellfire 1.5.4
  • Multiplayer Diablo 1.6.0-dev
  • Multiplayer Hellfire 1.6.0-dev

@kphoenix137
Copy link
Collaborator

kphoenix137 commented Feb 10, 2025 •
edited
Loading

Here's what I'm observing, using the latest master of 1.6.0-dev, Commit d92bdd2:

Multiplayer Diablo 1.5.4:

Image

Multiplayer Hellfire 1.5.4:

Image

Multiplayer Diablo 1.6.0-dev:

Image

Multiplayer Hellfire 1.6.0-dev:

Image

There is no morphing occuring, and the new feature that prevents invalid items from being usable is working as expected. The only thing I anticipate is happening is either you are using an older version of 1.6.0-dev, or you're using a modified build of 1.6.0-dev. Although I don't recall any commits being merged that fix any sort of morphing. Anyway, the problem isn't reproducible and you can resolve this by using the current latest master.

@StephenCWills
Copy link
Member

StephenCWills commented Feb 10, 2025 •
edited
Loading

Unable to reproduce, even on the same build version.

Image

@indigorain
Copy link
Author

I just downloaded a new beta to test. Are you loading the character twice?

Image

@StephenCWills
Copy link
Member

Oh, it wasn't clear from the steps that you need to load the save twice.

@StephenCWills StephenCWills linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with Hellfire items morphing when transferred to Diablo StephenCWills/DevilutionX
3 participants
@StephenCWills @indigorain @kphoenix137