Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] getting commission asset for trades #76

Open
ziggetty opened this issue May 15, 2021 · 3 comments
Open

[FEATURE] getting commission asset for trades #76

ziggetty opened this issue May 15, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ziggetty
Copy link

in the order table we get a value back for commission .

would be great also to get commissionAsset back.

normally i have enough BNB to pay for the commission,
but last week there was not, because i did sent BNB to an external wallet
and some trades had their commission in USDT which broke my total calculation
of paid commissions.

in the mean time i will code a workaround :-(

@ziggetty ziggetty added the enhancement New feature or request label May 15, 2021
@diegomanuel
Copy link
Owner

Hey @ziggetty yep agreed, commissionAsset should be included in the orders table, the only thing is that is going to break columns positions... but I definitively should include it soon 😅

@ziggetty
Copy link
Author

maybe add it as a the latest column, so that it will not break what is already retrieved.
not so neat, but .....

@SergeSyS
Copy link

SergeSyS commented Aug 1, 2021

Yes, it would be great to have!
In addition, when trade is made from margin account, the commission is taken in one of the coins from the traded pair.
So, if you trade with margin a lot, the commissions are calculated totally wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants