In PR #234 , generate_synthetic_density.py was refactored to extract common functions for any synthetic data generation. During the review, some minor changes were requested. They are addressed in the new generate_synthetic_sf.py, and for consistency, the density script should be updated too.
Specifically,
- Improve variable naming
occ_mode/values to occupancy_mode/values)
- Replace boilerplate
occ_values validation in __post_init__ with the refactored validate_occ_values() from synthetic_utils.py
- When validating structure file extension, warn legacy formats by having
VALID_EXTENSIONS and LEGACY_EXTENSIONS
In PR #234 ,
generate_synthetic_density.pywas refactored to extract common functions for any synthetic data generation. During the review, some minor changes were requested. They are addressed in the newgenerate_synthetic_sf.py, and for consistency, the density script should be updated too.Specifically,
occ_mode/valuestooccupancy_mode/values)occ_valuesvalidation in__post_init__with the refactoredvalidate_occ_values()fromsynthetic_utils.pyVALID_EXTENSIONSandLEGACY_EXTENSIONS