Skip to content

Commit bc706e6

Browse files
committed
update for node 18 workflow
1 parent 99b4ca4 commit bc706e6

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

.github/workflows/prebuilds.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
- "*"
88

99
env:
10-
NODE_VERSION: 16
10+
NODE_VERSION: 18
1111
MODULE_NAME: "fs-native-extensions"
1212
MODULE_VERSION: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || 'latest' }}
1313

@@ -21,6 +21,10 @@ jobs:
2121
target: ["android-arm", "android-arm64", "android-x64"]
2222

2323
steps:
24+
- name: Assert env.MODULE_VERSION is set
25+
if: ${{ env.MODULE_VERSION == '' }}
26+
run: echo "env.MODULE_VERSION must be set" && exit 1
27+
2428
- uses: actions/checkout@v4
2529

2630
- name: Setup NDK
@@ -46,7 +50,7 @@ jobs:
4650
working-directory: ./package
4751
env:
4852
ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
49-
run: npx --yes prebuild-for-nodejs-mobile@1.2.1 ${{ matrix.target }}
53+
run: npx --yes prebuild-for-nodejs-mobile@18.17.7 ${{ matrix.target }} --verbose
5054

5155
- name: Upload original prebuild artifacts # mostly for debugging purposes
5256
uses: actions/upload-artifact@v3
@@ -56,12 +60,9 @@ jobs:
5660

5761
# The below steps are needed for the release job
5862

59-
- name: Set NODE_ABI env var
60-
run: echo "NODE_ABI=$(node -e 'console.log(process.versions.modules)')" >> "$GITHUB_ENV"
61-
6263
- name: Derive release artifact name
6364
id: artifact-name
64-
run: echo "NAME=${{ env.MODULE_NAME }}-${{ env.MODULE_VERSION }}-node-${{ env.NODE_ABI }}-${{ matrix.TARGET }}" >> "$GITHUB_OUTPUT"
65+
run: echo "NAME=${{ env.MODULE_NAME }}-${{ env.MODULE_VERSION }}-${{ matrix.TARGET }}" >> "$GITHUB_OUTPUT"
6566

6667
- name: Prepare release artifact
6768
run: tar -czf ${{ steps.artifact-name.outputs.NAME }}.tar.gz --directory=./package/prebuilds/${{ matrix.TARGET }} .

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16
1+
18

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
### Requirements
88

9-
- Node >= 16 and npm < 9
9+
- Node 18
1010
- Android NDK 24.0.8215888
1111
- (optional) exported `ANDROID_NDK_PATH` environment variable
1212

0 commit comments

Comments
 (0)